You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
### Reason for this change
Closes#31979.
Replaces #29689.
In #11185, the `HttpDataSource` class was updated to extend `BackedDataSource` instead of `BaseDataSource`, however the `HttpDataSourceProps` type wasn't updated to reflect this change. This PR makes the `HttpDataSourceProps` type reflect the change.
### Description of changes
Makes the `HttpDataSourceProps` type extend `BackedDataSourceProps`, instead of `BaseDataSourceProps`. This means users are able to provide the `serviceRole` prop without getting a type error.
### Description of how you validated changes
The below code snippet no longer gives an incorrect type error when providing the serviceRole, as it did before:
```ts
import * as appsync from "aws-cdk-lib/aws-appsync";
import type { IRole } from "aws-cdk-lib/aws-iam";
declare const myApi: appsync.GraphqlApi;
declare const serviceRole: IRole;
const stepFunctionHttpDataSource = new appsync.HttpDataSource(
myApi,
"MyStepFunctionHTTPDataSource",
{
api: myApi,
authorizationConfig: {
signingRegion: "eu-west-1",
signingServiceName: "states",
},
endpoint: `https://states.eu-west-1.amazonaws.com`,
name: "StepFunctionHTTPDataSource",
// Providing the `serviceRole` now correctly DOESN'T throw a type error
serviceRole,
}
);
```
0 commit comments