Skip to content

Commit 1da883e

Browse files
authored
chore(dependencies): build with upgraded dependencies fails (#34957)
### Issue # (if applicable) Related to the #34888 PR. This PR contains the commit created by the Github action (that doesn't build) and another commit with the fix (making it easier to review). ### Reason for this change Version 6.0.0 of `@types/minimatch` got released on [NPM](https://www.npmjs.com/package/@types/minimatch) which deprecates the package and now the package doesn't contain code anymore (see files on NPM). We cannot upgrade our version of `glob` as this requires Node.js 20, see #33231 ### Description of changes Pin `@types/minimatch` to the previous working version. This has a side effect: lerna uses a pinned version of @types/minimatch (you can verify this with `yarn why @types/minimatch` with version `3.x.x`, now it will use `5.1.2`. As the build still passes I think this doesn't have consequences. I also removed `@types/minimatch` from the `nohoist` as this line doesn't have any effect since all the packages in the repo now use the same version. ### Description of how you validated changes Build, integ and unit tests. Ran `yarn why @types/minimatch` to confirm that all the packages use the same version of minimatch. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent a2b3e78 commit 1da883e

File tree

7 files changed

+236
-253
lines changed

7 files changed

+236
-253
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"jsii-diff": "1.112.0",
2929
"jsii-pacmak": "1.112.0",
3030
"jsii-reflect": "1.112.0",
31-
"lerna": "^8.2.2",
31+
"lerna": "^8.2.3",
3232
"nx": "^20",
3333
"semver": "^7.7.2",
3434
"standard-version": "^9.5.0",
@@ -41,7 +41,8 @@
4141
"markdown-it": "^12.3.2",
4242
"string-width": "^4.2.3",
4343
"@types/babel__traverse": "7.18.2",
44-
"@smithy/types": "3.5.0"
44+
"@smithy/types": "3.5.0",
45+
"@types/minimatch": "^5.1.2"
4546
},
4647
"repository": {
4748
"type": "git",
@@ -93,7 +94,6 @@
9394
"**/jszip",
9495
"**/jszip/**",
9596
"**/@types/glob",
96-
"**/@types/minimatch",
9797
"@aws-cdk/assertions-alpha/fs-extra",
9898
"@aws-cdk/assertions-alpha/fs-extra/**",
9999
"@aws-cdk/assertions/fs-extra",

packages/@aws-cdk-testing/framework-integ/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
"@aws-cdk/lambda-layer-kubectl-v33": "^2.0.0",
5050
"@aws-cdk/region-info": "0.0.0",
5151
"aws-cdk-lib": "0.0.0",
52-
"cdk8s": "2.69.74",
52+
"cdk8s": "2.69.76",
5353
"cdk8s-plus-27": "2.9.5",
5454
"constructs": "^10.0.0"
5555
},

packages/@aws-cdk/aws-eks-v2-alpha/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
"aws-cdk-lib": "0.0.0",
9898
"constructs": "^10.0.0",
9999
"sinon": "^9.2.4",
100-
"cdk8s": "2.69.74",
100+
"cdk8s": "2.69.76",
101101
"cdk8s-plus-27": "2.9.5"
102102
},
103103
"dependencies": {

packages/@aws-cdk/cx-api/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@
8787
"license": "Apache-2.0",
8888
"devDependencies": {
8989
"@aws-cdk/cdk-build-tools": "0.0.0",
90-
"@aws-cdk/cloud-assembly-schema": "^45.0.0",
90+
"@aws-cdk/cloud-assembly-schema": "^45.2.0",
9191
"@aws-cdk/pkglint": "0.0.0",
9292
"@types/jest": "^29.5.14",
9393
"@types/mock-fs": "^4.13.4",

packages/aws-cdk-lib/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
"dependencies": {
122122
"@aws-cdk/asset-awscli-v1": "2.2.242",
123123
"@aws-cdk/asset-node-proxy-agent-v6": "^2.1.0",
124-
"@aws-cdk/cloud-assembly-schema": "^45.0.0",
124+
"@aws-cdk/cloud-assembly-schema": "^45.2.0",
125125
"@balena/dockerignore": "^1.0.2",
126126
"case": "1.6.3",
127127
"fs-extra": "^11.3.0",
@@ -163,13 +163,13 @@
163163
"@smithy/util-stream": "3.3.4",
164164
"@types/aws-lambda": "^8.10.150",
165165
"@types/jest": "^29.5.14",
166-
"@types/lodash": "^4.17.18",
166+
"@types/lodash": "^4.17.20",
167167
"@types/punycode": "^2.1.4",
168168
"@types/mime-types": "^2.1.4",
169169
"@aws-cdk/lazify": "0.0.0",
170170
"aws-sdk-client-mock": "4.1.0",
171171
"aws-sdk-client-mock-jest": "4.1.0",
172-
"cdk8s": "2.69.74",
172+
"cdk8s": "2.69.76",
173173
"constructs": "^10.0.0",
174174
"delay": "5.0.0",
175175
"esbuild": "^0.25.0",

tools/@aws-cdk/cdk-build-tools/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@
6161
"glob": "^7.2.3",
6262
"jest": "^29.7.0",
6363
"jest-junit": "^13.2.0",
64-
"jsii": "~5.7.18",
65-
"jsii-rosetta": "~5.7.18",
64+
"jsii": "~5.7.20",
65+
"jsii-rosetta": "~5.7.20",
6666
"jsii-pacmak": "1.112.0",
6767
"jsii-reflect": "1.112.0",
6868
"markdownlint-cli": "^0.45.0",

0 commit comments

Comments
 (0)