You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore(dependencies): build with upgraded dependencies fails (#34957)
### Issue # (if applicable)
Related to the #34888 PR.
This PR contains the commit created by the Github action (that doesn't build) and another commit with the fix (making it easier to review).
### Reason for this change
Version 6.0.0 of `@types/minimatch` got released on [NPM](https://www.npmjs.com/package/@types/minimatch) which deprecates the package and now the package doesn't contain code anymore (see files on NPM).
We cannot upgrade our version of `glob` as this requires Node.js 20, see #33231
### Description of changes
Pin `@types/minimatch` to the previous working version.
This has a side effect: lerna uses a pinned version of @types/minimatch (you can verify this with `yarn why @types/minimatch` with version `3.x.x`, now it will use `5.1.2`. As the build still passes I think this doesn't have consequences.
I also removed `@types/minimatch` from the `nohoist` as this line doesn't have any effect since all the packages in the repo now use the same version.
### Description of how you validated changes
Build, integ and unit tests. Ran `yarn why @types/minimatch` to confirm that all the packages use the same version of minimatch.
### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
0 commit comments