Skip to content

Commit 5470eb5

Browse files
committed
Sort more enum values to create more consistency (#3161)
1 parent 2549fd2 commit 5470eb5

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

scripts/update_schemas_from_aws_api.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def write_db_cluster(results):
6363
"then": {
6464
"properties": {
6565
"Engine": {
66-
"enum": engines,
66+
"enum": sorted(engines),
6767
}
6868
}
6969
},
@@ -85,7 +85,9 @@ def write_db_cluster(results):
8585
"required": ["Engine", "EngineVersion"],
8686
},
8787
"then": {
88-
"properties": {"EngineVersion": {"enum": results.get(engine)}}
88+
"properties": {
89+
"EngineVersion": {"enum": sorted(results.get(engine))}
90+
}
8991
},
9092
}
9193
)
@@ -132,7 +134,7 @@ def write_db_instance(results):
132134
"then": {
133135
"properties": {
134136
"Engine": {
135-
"enum": engines,
137+
"enum": sorted(engines),
136138
}
137139
}
138140
},
@@ -156,7 +158,9 @@ def write_db_instance(results):
156158
"required": ["Engine", "EngineVersion"],
157159
},
158160
"then": {
159-
"properties": {"EngineVersion": {"enum": results.get(engine)}}
161+
"properties": {
162+
"EngineVersion": {"enum": sorted(results.get(engine))}
163+
}
160164
},
161165
}
162166
)

scripts/update_schemas_from_boto.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1056,7 +1056,7 @@ def build_resource_type_patches(dir: str, resource_patches: ResourcePatch):
10561056
{
10571057
"op": "add",
10581058
"path": f"{patch.path}/enum",
1059-
"value": enums,
1059+
"value": sorted(enums),
10601060
}
10611061
)
10621062

scripts/update_specs_from_pricing.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ def write_output(resource, filename, obj):
370370
"_description": "Automatically updated using update_specs_from_pricing",
371371
}
372372
for region, values in obj.items():
373-
output[region] = {"enum": list(values)}
373+
output[region] = {"enum": sorted(list(values))}
374374

375375
with open(filename, "w+", encoding="utf-8") as f:
376376
json.dump(output, f, indent=1, sort_keys=True, separators=(",", ": "))

0 commit comments

Comments
 (0)