Skip to content

Commit 20a3646

Browse files
authored
Fixed argument prefix warnings (#3594)
If I run an app using avo with warnings enabled I get a LOT of warnings like this: avo-3.16.1/app/components/avo/fields/files_field/edit_component.html.erb:1: warning: `**' interpreted as argument prefix This is happening because a function is being called with `**` as the first argument but there are no brackets around the arguments. Adding brackets fixes the warning but it does not change the meaning, so I've done that for all field components.
1 parent 041d00f commit 20a3646

File tree

77 files changed

+80
-80
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

77 files changed

+80
-80
lines changed

app/components/avo/fields/area_field/edit_component.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<%= field_wrapper **field_wrapper_args do %>
1+
<%= field_wrapper(**field_wrapper_args) do %>
22
<%= @form.text_field field.id,
33
value: field.value.to_s,
44
class: classes("w-full"),

app/components/avo/fields/area_field/show_component.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<%= field_wrapper **field_wrapper_args do %>
1+
<%= field_wrapper(**field_wrapper_args) do %>
22
<% if field.value.present? %>
33
<%= area_map field.map_data, **field.mapkick_options %>
44
<% else %>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
<%= index_field_wrapper **field_wrapper_args, flush: true do %>
1+
<%= index_field_wrapper(**field_wrapper_args, flush: true) do %>
22
<%= render Avo::Fields::Common::BadgeViewerComponent.new value: @field.value, options: @field.options %>
33
<% end %>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
<%= field_wrapper **field_wrapper_args do %>
1+
<%= field_wrapper(**field_wrapper_args) do %>
22
<%= render Avo::Fields::Common::BadgeViewerComponent.new value: @field.value, options: @field.options %>
33
<% end %>

app/components/avo/fields/belongs_to_field/edit_component.html.erb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
data-association="<%= @field.id %>"
66
data-association-class="<%= @field&.target_resource&.model_class || nil %>"
77
>
8-
<%= field_wrapper **field_wrapper_args, label_for: @field.polymorphic_form_field_label, help: @field.polymorphic_help || '' do %>
8+
<%= field_wrapper(**field_wrapper_args, label_for: @field.polymorphic_form_field_label, help: @field.polymorphic_help || '') do %>
99
<%= @form.select @field.type_input_foreign_key, @field.types.map { |type| [Avo.resource_manager.get_resource_by_model_class(type.to_s).name, type.to_s] },
1010
{
1111
value: @field.value,
@@ -32,7 +32,7 @@
3232
<% @field.types.each do |type| %>
3333
<template data-belongs-to-field-target="type" data-type="<%= type %>">
3434
<div data-polymorphic-type="<%= type %>">
35-
<%= field_wrapper **field_wrapper_args.merge!(data: reload_data), label: Avo.resource_manager.get_resource_by_model_class(type.to_s).name do %>
35+
<%= field_wrapper(**field_wrapper_args.merge!(data: reload_data), label: Avo.resource_manager.get_resource_by_model_class(type.to_s).name) do %>
3636
<% if @field.is_searchable? %>
3737
<%= render Avo::Pro::SearchableAssociations::AutocompleteComponent.new form: @form,
3838
disabled: disabled,
@@ -88,7 +88,7 @@
8888
<% end %>
8989
</div>
9090
<% else %>
91-
<%= field_wrapper **field_wrapper_args.merge!(data: reload_data) do %>
91+
<%= field_wrapper(**field_wrapper_args.merge!(data: reload_data)) do %>
9292
<% if @field.is_searchable? %>
9393
<%= render Avo::Pro::SearchableAssociations::AutocompleteComponent.new form: @form,
9494
field: @field,

app/components/avo/fields/belongs_to_field/index_component.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<%= index_field_wrapper **field_wrapper_args do %>
1+
<%= index_field_wrapper(**field_wrapper_args) do %>
22
<%= link_to @field.label, helpers.resource_view_path(
33
record: @field.index_link_to_record,
44
resource: @field.index_link_to_resource
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
<%= field_wrapper **field_wrapper_args do %>
1+
<%= field_wrapper(**field_wrapper_args) do %>
22
<%= link_to @field.label, resource_view_path, data: {turbo_frame: @field.target} %>
33
<% end %>

app/components/avo/fields/boolean_field/edit_component.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<%= field_wrapper **field_wrapper_args do %>
1+
<%= field_wrapper(**field_wrapper_args) do %>
22
<div class="h-8 flex items-center">
33
<%= @form.check_box @field.id,
44
value: @field.value,
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
<%= index_field_wrapper **field_wrapper_args, flush: true do %>
1+
<%= index_field_wrapper(**field_wrapper_args, flush: true) do %>
22
<%= render Avo::Fields::Common::BooleanCheckComponent.new checked: @field.value %>
33
<% end %>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
<%= field_wrapper **field_wrapper_args do %>
1+
<%= field_wrapper(**field_wrapper_args) do %>
22
<%= render Avo::Fields::Common::BooleanCheckComponent.new checked: @field.value %>
33
<% end %>

0 commit comments

Comments
 (0)