Skip to content

Commit 82d5b67

Browse files
Move --config-settings structs into uv-distribution-types (#15278)
## Summary This breaks up a cycle I'm running into in incorporating the build configuration into our cache keys. This is actually a type that ends up in the frontend build system, etc., so I think it makes more sense here anyway (as opposed to `uv-configuration` which tend to be our own user-facing types).
1 parent d8d4f02 commit 82d5b67

File tree

23 files changed

+75
-77
lines changed

23 files changed

+75
-77
lines changed

Cargo.lock

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/uv-bench/benches/uv.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,13 @@ mod resolver {
8686
use uv_cache::Cache;
8787
use uv_client::RegistryClient;
8888
use uv_configuration::{
89-
BuildOptions, Concurrency, ConfigSettings, Constraints, IndexStrategy,
90-
PackageConfigSettings, Preview, SourceStrategy,
89+
BuildOptions, Concurrency, Constraints, IndexStrategy, Preview, SourceStrategy,
9190
};
9291
use uv_dispatch::{BuildDispatch, SharedState};
9392
use uv_distribution::DistributionDatabase;
9493
use uv_distribution_types::{
95-
DependencyMetadata, ExtraBuildRequires, ExtraBuildVariables, IndexLocations, RequiresPython,
94+
ConfigSettings, DependencyMetadata, ExtraBuildRequires, ExtraBuildVariables,
95+
IndexLocations, PackageConfigSettings, RequiresPython,
9696
};
9797
use uv_install_wheel::LinkMode;
9898
use uv_pep440::Version;

crates/uv-build-frontend/src/lib.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,11 @@ use tracing::{Instrument, debug, info_span, instrument, warn};
3030

3131
use uv_cache_key::cache_digest;
3232
use uv_configuration::Preview;
33-
use uv_configuration::{BuildKind, BuildOutput, ConfigSettings, SourceStrategy};
33+
use uv_configuration::{BuildKind, BuildOutput, SourceStrategy};
3434
use uv_distribution::BuildRequires;
35-
use uv_distribution_types::{ExtraBuildRequires, IndexLocations, Requirement, Resolution};
35+
use uv_distribution_types::{
36+
ConfigSettings, ExtraBuildRequires, IndexLocations, Requirement, Resolution,
37+
};
3638
use uv_fs::LockedFile;
3739
use uv_fs::{PythonExt, Simplified};
3840
use uv_pep440::Version;

crates/uv-cli/src/lib.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,13 @@ use clap::{Args, Parser, Subcommand};
1010

1111
use uv_cache::CacheArgs;
1212
use uv_configuration::{
13-
ConfigSettingEntry, ConfigSettingPackageEntry, ExportFormat, IndexStrategy,
14-
KeyringProviderType, PackageNameSpecifier, PreviewFeatures, ProjectBuildBackend, TargetTriple,
15-
TrustedHost, TrustedPublishing, VersionControlSystem,
13+
ExportFormat, IndexStrategy, KeyringProviderType, PackageNameSpecifier, PreviewFeatures,
14+
ProjectBuildBackend, TargetTriple, TrustedHost, TrustedPublishing, VersionControlSystem,
15+
};
16+
use uv_distribution_types::{
17+
ConfigSettingEntry, ConfigSettingPackageEntry, Index, IndexUrl, Origin, PipExtraIndex,
18+
PipFindLinks, PipIndex,
1619
};
17-
use uv_distribution_types::{Index, IndexUrl, Origin, PipExtraIndex, PipFindLinks, PipIndex};
1820
use uv_normalize::{ExtraName, GroupName, PackageName, PipGroupName};
1921
use uv_pep508::{MarkerTree, Requirement};
2022
use uv_pypi_types::VerbatimParsedUrl;

crates/uv-cli/src/options.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use anstream::eprintln;
22

33
use uv_cache::Refresh;
4-
use uv_configuration::{ConfigSettings, PackageConfigSettings};
4+
use uv_distribution_types::{ConfigSettings, PackageConfigSettings};
55
use uv_resolver::{ExcludeNewer, ExcludeNewerPackage, PrereleaseMode};
66
use uv_settings::{Combine, PipOptions, ResolverInstallerOptions, ResolverOptions};
77
use uv_warnings::owo_colors::OwoColorize;

crates/uv-configuration/Cargo.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ workspace = true
1919
uv-auth = { workspace = true }
2020
uv-cache = { workspace = true }
2121
uv-cache-info = { workspace = true }
22-
uv-cache-key = { workspace = true }
2322
uv-distribution-types = { workspace = true }
2423
uv-git = { workspace = true }
2524
uv-normalize = { workspace = true }
@@ -39,7 +38,6 @@ same-file = { workspace = true }
3938
schemars = { workspace = true, optional = true }
4039
serde = { workspace = true }
4140
serde-untagged = { workspace = true }
42-
serde_json = { workspace = true }
4341
thiserror = { workspace = true }
4442
tracing = { workspace = true }
4543
url = { workspace = true }

crates/uv-configuration/src/lib.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
pub use authentication::*;
22
pub use build_options::*;
33
pub use concurrency::*;
4-
pub use config_settings::*;
54
pub use constraints::*;
65
pub use dependency_groups::*;
76
pub use dry_run::*;
@@ -26,7 +25,6 @@ pub use vcs::*;
2625
mod authentication;
2726
mod build_options;
2827
mod concurrency;
29-
mod config_settings;
3028
mod constraints;
3129
mod dependency_groups;
3230
mod dry_run;

crates/uv-dispatch/src/lib.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,15 @@ use uv_build_frontend::{SourceBuild, SourceBuildContext};
1717
use uv_cache::Cache;
1818
use uv_client::RegistryClient;
1919
use uv_configuration::{
20-
BuildKind, BuildOptions, ConfigSettings, Constraints, IndexStrategy, PackageConfigSettings,
21-
Preview, Reinstall, SourceStrategy,
20+
BuildKind, BuildOptions, Constraints, IndexStrategy, Preview, Reinstall, SourceStrategy,
2221
};
2322
use uv_configuration::{BuildOutput, Concurrency};
2423
use uv_distribution::DistributionDatabase;
2524
use uv_distribution_filename::DistFilename;
2625
use uv_distribution_types::{
27-
CachedDist, DependencyMetadata, ExtraBuildRequires, ExtraBuildVariables, Identifier,
28-
IndexCapabilities, IndexLocations, IsBuildBackendError, Name, Requirement, Resolution,
29-
SourceDist, VersionOrUrlRef,
26+
CachedDist, ConfigSettings, DependencyMetadata, ExtraBuildRequires, ExtraBuildVariables,
27+
Identifier, IndexCapabilities, IndexLocations, IsBuildBackendError, Name,
28+
PackageConfigSettings, Requirement, Resolution, SourceDist, VersionOrUrlRef,
3029
};
3130
use uv_git::GitResolver;
3231
use uv_installer::{Installer, Plan, Planner, Preparer, SitePackages};

crates/uv-distribution-types/src/lib.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ pub use crate::any::*;
5757
pub use crate::build_requires::*;
5858
pub use crate::buildable::*;
5959
pub use crate::cached::*;
60+
pub use crate::config_settings::*;
6061
pub use crate::dependency_metadata::*;
6162
pub use crate::diagnostic::*;
6263
pub use crate::dist_error::*;
@@ -86,6 +87,7 @@ mod any;
8687
mod build_requires;
8788
mod buildable;
8889
mod cached;
90+
mod config_settings;
8991
mod dependency_metadata;
9092
mod diagnostic;
9193
mod dist_error;

0 commit comments

Comments
 (0)