[pyupgrade] make fix unsafe if it deletes comments (UP010, unnecessary-future-import) (#18291)

Author: chirizxc

crates/ruff_linter/resources/test/fixtures/pyupgrade/UP010.py

@@ -12,3 +12,4 @@
 if True:
     from __future__ import generator_stop
     from __future__ import invalid_module, generators
+    from __future__ import generators  # comment

crates/ruff_linter/src/rules/pyupgrade/rules/unnecessary_future_import.rs

@@ -1,7 +1,7 @@
 use itertools::Itertools;
 use ruff_python_ast::{Alias, Stmt};
 
-use ruff_diagnostics::{AlwaysFixableViolation, Diagnostic, Fix};
+use ruff_diagnostics::{AlwaysFixableViolation, Applicability, Diagnostic, Fix};
 use ruff_macros::{ViolationMetadata, derive_message_formats};
 use ruff_text_size::Ranged;
 
@@ -123,9 +123,19 @@ pub(crate) fn unnecessary_future_import(checker: &Checker, stmt: &Stmt, names: &
             checker.stylist(),
             checker.indexer(),
         )?;
-        Ok(Fix::safe_edit(edit).isolate(Checker::isolation(
-            checker.semantic().current_statement_parent_id(),
-        )))
+
+        let range = edit.range();
+        let applicability = if checker.comment_ranges().intersects(range) {
+            Applicability::Unsafe
+        } else {
+            Applicability::Safe
+        };
+
+        Ok(
+            Fix::applicable_edit(edit, applicability).isolate(Checker::isolation(
+                checker.semantic().current_statement_parent_id(),
+            )),
+        )
     });
     checker.report_diagnostic(diagnostic);
 }

crates/ruff_linter/src/rules/pyupgrade/snapshots/ruff_linter__rules__pyupgrade__tests__UP010.py.snap

@@ -156,6 +156,7 @@ UP010.py:13:5: UP010 [*] Unnecessary `__future__` import `generator_stop` for ta
 13 |     from __future__ import generator_stop
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ UP010
 14 |     from __future__ import invalid_module, generators
+15 |     from __future__ import generators  # comment
    |
    = help: Remove unnecessary `__future__` import
 
@@ -165,13 +166,15 @@ UP010.py:13:5: UP010 [*] Unnecessary `__future__` import `generator_stop` for ta
 12 12 | if True:
 13    |-    from __future__ import generator_stop
 14 13 |     from __future__ import invalid_module, generators
+15 14 |     from __future__ import generators  # comment
 
 UP010.py:14:5: UP010 [*] Unnecessary `__future__` import `generators` for target Python version
    |
 12 | if True:
 13 |     from __future__ import generator_stop
 14 |     from __future__ import invalid_module, generators
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ UP010
+15 |     from __future__ import generators  # comment
    |
    = help: Remove unnecessary `__future__` import
 
@@ -181,3 +184,19 @@ UP010.py:14:5: UP010 [*] Unnecessary `__future__` import `generators` for target
 13 13 |     from __future__ import generator_stop
 14    |-    from __future__ import invalid_module, generators
    14 |+    from __future__ import invalid_module
+15 15 |     from __future__ import generators  # comment
+
+UP010.py:15:5: UP010 [*] Unnecessary `__future__` import `generators` for target Python version
+   |
+13 |     from __future__ import generator_stop
+14 |     from __future__ import invalid_module, generators
+15 |     from __future__ import generators  # comment
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ UP010
+   |
+   = help: Remove unnecessary `__future__` import
+
+ℹ Unsafe fix
+12 12 | if True:
+13 13 |     from __future__ import generator_stop
+14 14 |     from __future__ import invalid_module, generators
+15    |-    from __future__ import generators  # comment