revert now-unnecessary change

Author: AlexWaygood

crates/red_knot_python_semantic/src/symbol.rs

@@ -752,7 +752,9 @@ fn symbol_from_bindings_impl<'db>(
 
     if let Some(first) = types.next() {
         let boundness = match unbound_visibility {
-            Truthiness::AlwaysTrue => return Symbol::Unbound,
+            Truthiness::AlwaysTrue => {
+                unreachable!("If we have at least one binding, the scope-start should not be definitely visible")
+            }
             Truthiness::AlwaysFalse => Boundness::Bound,
             Truthiness::Ambiguous => Boundness::PossiblyUnbound,
         };
@@ -841,7 +843,9 @@ fn symbol_from_declarations_impl<'db>(
         };
         if conflicting.is_empty() {
             let boundness = match undeclared_visibility {
-                Truthiness::AlwaysTrue => return Ok(Symbol::Unbound.into()),
+                Truthiness::AlwaysTrue => {
+                    unreachable!("If we have at least one declaration, the scope-start should not be definitely visible")
+                }
                 Truthiness::AlwaysFalse => Boundness::Bound,
                 Truthiness::Ambiguous => Boundness::PossiblyUnbound,
             };

crates/red_knot_python_semantic/src/types/class.rs

@@ -401,7 +401,8 @@ impl<'db> Class<'db> {
     /// directly. Use [`Class::class_member`] if you require a method that will
     /// traverse through the MRO until it finds the member.
     pub(super) fn own_class_member(self, db: &'db dyn Db, name: &str) -> SymbolAndQualifiers<'db> {
-        class_symbol(db, self.body_scope(db), name)
+        let body_scope = self.body_scope(db);
+        class_symbol(db, body_scope, name)
     }
 
     /// Returns the `name` attribute of an instance of this class.