Disable ThrowForPartialCookies by default for ChunkingCookieManager and SystemWebChunkingCookieManager (#488)

Author: kevinchalet

src/Microsoft.Owin.Host.SystemWeb/SystemWebChunkingCookieManager.cs

@@ -21,7 +21,6 @@ public class SystemWebChunkingCookieManager : ICookieManager
         public SystemWebChunkingCookieManager()
         {
             ChunkSize = 4090;
-            ThrowForPartialCookies = true;
             Fallback = new ChunkingCookieManager();
         }
 
@@ -42,6 +41,11 @@ public SystemWebChunkingCookieManager()
         /// <summary>
         /// Throw if not all chunks of a cookie are available on a request for re-assembly.
         /// </summary>
+        /// <remarks>
+        /// By default, this property is set to <see langword="false"/>. In this case,
+        /// <see cref="GetRequestCookie(IOwinContext, string)"/> returns "chunks:[number of chunks]"
+        /// instead of causing a <see cref="FormatException"/> if one of the chunks is missing.
+        /// </remarks>
         public bool ThrowForPartialCookies { get; set; }
 
         // Parse the "chunks:XX" to determine how many chunks there should be.

src/Microsoft.Owin/Infrastructure/ChunkingCookieManager.cs

@@ -21,7 +21,6 @@ public class ChunkingCookieManager : ICookieManager
         public ChunkingCookieManager()
         {
             ChunkSize = 4090;
-            ThrowForPartialCookies = true;
         }
 
         /// <summary>
@@ -36,6 +35,11 @@ public ChunkingCookieManager()
         /// <summary>
         /// Throw if not all chunks of a cookie are available on a request for re-assembly.
         /// </summary>
+        /// <remarks>
+        /// By default, this property is set to <see langword="false"/>. In this case,
+        /// <see cref="GetRequestCookie(IOwinContext, string)"/> returns "chunks:[number of chunks]"
+        /// instead of causing a <see cref="FormatException"/> if one of the chunks is missing.
+        /// </remarks>
         public bool ThrowForPartialCookies { get; set; }
 
         // Parse the "chunks:XX" to determine how many chunks there should be.

tests/Microsoft.Owin.Tests/CookieChunkingTests.cs

@@ -120,7 +120,7 @@ public void GetLargeChunkedCookieWithMissingChunk_ThrowingEnabled_Throws()
                 "TestCookieC6=JKLMNOPQR",
                 "TestCookieC7=STUVWXYZ");
 
-            Assert.Throws<FormatException>(() => new ChunkingCookieManager().GetRequestCookie(context, "TestCookie"));
+            Assert.Throws<FormatException>(() => new ChunkingCookieManager { ThrowForPartialCookies = true }.GetRequestCookie(context, "TestCookie"));
         }
 
         [Fact]