Add support for plugins

[titanous]

This PR implements all of the wiring necessary to use SWC plugins.

• Add a swc_plugin macro/rule pair that creates a target with the necessary providers:
  • a DefaultInfo pointing at a wasm file or an npm package containing a wasm file as the main entrypoint in the package.json
  • a new SwcPluginConfigInfo holding the plugin configuration
• Add a plugins attr to swc_compile and swc, taking a list of plugin targets, along with helpers to inject the plugin config.

[CLAassistant]

All committers have signed the CLA.

[alexeagle]

Ooh, that's interesting. Thanks for working on this! Let's see what they decide upstream about the resolution pathing.

[realtimetodie]

This really nice. Thank you. My concern is the substitution of the user's configuration. It just feels wrong and complicates things.

If you are already patching the cli, I would go a step further and introduce a new --plugin multi-option. This can be done during the initialization phase

https://github.com/swc-project/swc/blob/47cc6446d4e2cd86846e8de5b67d279ae463dcc4/bindings/swc_cli/src/commands/compile.rs#L268

[titanous]

I agree that adding a CLI flag makes sense. It also may be better for upstream because they can punt on relative paths in the config. I came up with this design when I thought that it could work without modifying SWC at all 😅

[realtimetodie]

I think by adding a new option you can also resolve the issue with the base path in swc-project/swc#6800.

Providing a path using the --plugin option should work in the same way as providing a path using a --config option.

[titanous]

Updated to use CLI arguments added in swc-project/swc#6811

Much better, thanks for the suggestion, @realtimetodie!

[alexeagle]

Hey @titanous thanks for the contribution, sorry I didn't get to it earlier. I rebased over #146 which mirrored the latest swc version, and dropped your commit that switched to your custom fork.

I think this would be nice to get into the 1.0 :)

[titanous]

swc-project/swc#6835 has now been merged, so as soon as a new version of SWC is released this PR should be ready to go.

[alexeagle]

upstream cut the release, so I think this is unblocked now @titanous :)

[titanous]

Indeed, the tests are now passing locally and this is ready for review.

[alexeagle]

The added wasm file is 2MB which will severely bloat our download for users of the ruleset. Can we fetch it with http_file from somewhere instead?

[realtimetodie]

Yes, we should not add binary files, wasm or not.

Luckily, there is rules_rust which can be used to ceate a plugin with the wasm bindgen rules.

https://bazelbuild.github.io/rules_rust/rust_wasm_bindgen.html

Rust wasm bindgen is a Rust library and CLI tool that facilitates high-level interactions between wasm modules and JavaScript. This would also be a great example for users.

[titanous]

PTAL

[titanous]

PTAL

[alexeagle]

Looks great, thank you!

[alexeagle]

very creative :)

[titanous]

ha, I was pretty proud of myself when I came up with that one