fix: avoid issuing invalid wait-for-it command (#1149)

Signed-off-by: Marko Strukelj <[email protected]>

Co-authored-by: Bartosz Majsak <[email protected]>

Author: mstruk

docker/docker/src/main/java/org/arquillian/cube/docker/impl/await/PollingAwaitStrategy.java

@@ -111,7 +111,7 @@ public boolean await() {
                     } catch (UnsupportedOperationException e) {
                         // In case of not having ss command installed on container, it automatically fall back to waitforit approach
                         try {
-                            if (!executeWaitForIt(portBindings.getInternalIP(), port)) {
+                            if (!executeWaitForIt(getReadyCheckIp(portBindings), port)) {
                                 return false;
                             }
                         } catch (UnsupportedOperationException ex) {
@@ -132,7 +132,7 @@ public boolean await() {
                 }
                 break;
                 case "waitforit": {
-                    if (!executeWaitForIt(portBindings.getInternalIP(), port)) {
+                    if (!executeWaitForIt(getReadyCheckIp(portBindings), port)) {
                         return false;
                     }
                 }
@@ -142,6 +142,17 @@ public boolean await() {
         return true;
     }
 
+    private String getReadyCheckIp(HasPortBindings portBindings) {
+        String ip = portBindings.getInternalIP();
+        if (ip == null || "".equals(ip)) {
+            ip = portBindings.getContainerIP();
+        }
+        if (ip == null || "".equals(ip)) {
+            ip = "localhost";
+        }
+        return ip;
+    }
+
     private boolean executeWaitForIt(String containerIp, int port) {
 
         // We copy our wait-for-it-sh.sh file form classpath