File tree Expand file tree Collapse file tree 1 file changed +10
-0
lines changed
arduino-ide-extension/src/electron-browser/theia/core Expand file tree Collapse file tree 1 file changed +10
-0
lines changed Original file line number Diff line number Diff line change 88} from '@theia/core/lib/common/menu' ;
99import {
1010 ElectronMainMenuFactory as TheiaElectronMainMenuFactory ,
11+ ElectronMenuItemRole ,
1112 ElectronMenuOptions ,
1213} from '@theia/core/lib/electron-browser/menu/electron-main-menu-factory' ;
1314import {
@@ -96,6 +97,15 @@ export class ElectronMainMenuFactory extends TheiaElectronMainMenuFactory {
9697 return { label, submenu } ;
9798 }
9899
100+ // eslint-disable-next-line @typescript-eslint/no-unused-vars
101+ protected override roleFor ( id : string ) : ElectronMenuItemRole | undefined {
102+ // MenuItem `roles` are completely broken on macOS:
103+ // - https://github.com/eclipse-theia/theia/issues/11217,
104+ // - https://github.com/arduino/arduino-ide/issues/969
105+ // IDE2 uses commands instead.
106+ return undefined ;
107+ }
108+
99109 protected handleElectronDefault (
100110 menuNode : CompositeMenuNode ,
101111 args : any [ ] = [ ] ,
You can’t perform that action at this time.
0 commit comments