fix: make programmer optional for debug --info

Removed premature `programmer` check from the IDE. Let the CLI handle
if no programmer is selected.
A platform might have zero programmers.
For example, `Raspberry Pi Pico boards`, `STM32`, etc.

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

arduino-ide-extension/src/browser/contributions/debug.ts

@@ -398,12 +398,9 @@ export async function isDebugEnabled(
       `Failed to append boards config to the FQBN. Original FQBN was: ${fqbn}`
     );
   }
-  if (!data.selectedProgrammer) {
-    throw new Error(noProgrammerSelectedFor(board.name));
-  }
   const params = {
     fqbn: fqbnWithConfig,
-    programmer: data.selectedProgrammer.id,
+    programmer: data.selectedProgrammer?.id,
   };
   try {
     const debugFqbn = await checkDebugEnabled(params);
@@ -443,13 +440,3 @@ export function debuggingNotSupported(boardName: string): string {
     boardName
   );
 }
-/**
- * (non-API)
- */
-export function noProgrammerSelectedFor(boardName: string): string {
-  return nls.localize(
-    'arduino/debug/noProgrammerSelectedFor',
-    "No programmer selected for '{0}'",
-    boardName
-  );
-}

arduino-ide-extension/src/common/protocol/boards-service.ts

@@ -95,7 +95,7 @@ export interface CheckDebugEnabledParams {
    * The FQBN might contain custom board config options. For example, `arduino:esp32:nano_nora:USBMode=hwcdc,option2=value2`.
    */
   readonly fqbn: string;
-  readonly programmer: string;
+  readonly programmer?: string;
 }
 
 export interface BoardSearch extends Searchable.Options {

arduino-ide-extension/src/node/boards-service-impl.ts

@@ -178,7 +178,7 @@ export class BoardsServiceImpl
     const req = new IsDebugSupportedRequest()
       .setInstance(instance)
       .setFqbn(fqbn)
-      .setProgrammer(programmer);
+      .setProgrammer(programmer ?? '');
     try {
       const debugFqbn = await new Promise<string>((resolve, reject) =>
         client.isDebugSupported(req, (err, resp) => {

arduino-ide-extension/src/test/browser/debug.test.ts

@@ -28,7 +28,6 @@ import {
   debuggingNotSupported,
   isDebugEnabled,
   noPlatformInstalledFor,
-  noProgrammerSelectedFor,
 } from '../../browser/contributions/debug';
 import { NotificationCenter } from '../../browser/notification-center';
 import { noBoardSelected } from '../../common/nls';
@@ -117,37 +116,34 @@ describe('debug', () => {
       );
     });
 
-    it('should error when no programmer selected', async () => {
-      const copyData: Mutable<BoardsDataStore.Data> = deepClone(data);
-      delete copyData.selectedProgrammer;
+    it('should error when it fails to get the debug info from the CLI', async () => {
       await rejects(
         isDebugEnabled(
           board,
           () => boardDetails,
-          () => copyData,
+          () => data,
           (fqbn) => fqbn,
-          unexpectedCall()
+          () => {
+            throw new Error('unhandled error');
+          }
         ),
         (reason) =>
           reason instanceof Error &&
-          reason.message === noProgrammerSelectedFor(board.name)
+          reason.message === debuggingNotSupported(board.name)
       );
     });
 
-    it('should error when it fails to get the debug info from the CLI', async () => {
-      await rejects(
+    it('should resolve when no programmer is selected (arduino/arduino-cli#2540)', async () => {
+      const copyData: Mutable<BoardsDataStore.Data> = deepClone(data);
+      delete copyData.selectedProgrammer;
+      await doesNotReject(
         isDebugEnabled(
           board,
           () => boardDetails,
-          () => data,
+          () => copyData,
           (fqbn) => fqbn,
-          () => {
-            throw new Error('unhandled error');
-          }
-        ),
-        (reason) =>
-          reason instanceof Error &&
-          reason.message === debuggingNotSupported(board.name)
+          async () => fqbn
+        )
       );
     });
 

i18n/en.json

@@ -213,7 +213,6 @@
       "debuggingNotSupported": "Debugging is not supported by '{0}'",
       "getDebugInfo": "Getting debug info...",
       "noPlatformInstalledFor": "Platform is not installed for '{0}'",
-      "noProgrammerSelectedFor": "No programmer selected for '{0}'",
       "optimizeForDebugging": "Optimize for Debugging",
       "sketchIsNotCompiled": "Sketch '{0}' must be verified before starting a debug session. Please verify the sketch and start debugging again. Do you want to verify the sketch now?"
     },