Skip to content

Commit 5ba9087

Browse files
OriGlassmangeyslan
authored andcommitted
fix: process_execute_failed use correct lru
- use the correct LRU (base events) - remove unused LRU
1 parent 312a122 commit 5ba9087

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

pkg/events/derive/process_execute_failed.go

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@ import (
1212

1313
// ExecFailedGenerator is the object which implement the ProcessExecuteFailed event derivation
1414
type ExecFailedGenerator struct {
15-
execEndInfo *lru.Cache[int, execEndInfo]
16-
baseEvents *lru.Cache[int, *trace.Event]
17-
deriveBase deriveBase
15+
baseEvents *lru.Cache[int, *trace.Event]
16+
deriveBase deriveBase
1817
}
1918

2019
// InitProcessExecuteFailedGenerator initialize a new generator for the ProcessExecuteFailed event.
@@ -23,18 +22,13 @@ func InitProcessExecuteFailedGenerator() (*ExecFailedGenerator, error) {
2322
// For now, we assume that the current value is sufficient
2423
const executionEventsCacheSize = 16
2524

26-
executeProcsCache, err := lru.New[int, execEndInfo](executionEventsCacheSize)
27-
if err != nil {
28-
return nil, err
29-
}
3025
executeParamsCache, err := lru.New[int, *trace.Event](executionEventsCacheSize)
3126
if err != nil {
3227
return nil, err
3328
}
3429
return &ExecFailedGenerator{
35-
execEndInfo: executeProcsCache,
36-
baseEvents: executeParamsCache,
37-
deriveBase: makeDeriveBase(events.ProcessExecuteFailed),
30+
baseEvents: executeParamsCache,
31+
deriveBase: makeDeriveBase(events.ProcessExecuteFailed),
3832
}, nil
3933
}
4034

@@ -78,7 +72,7 @@ func (gen *ExecFailedGenerator) deriveEvent(event *trace.Event) (
7872
// handleExecFinished will add info on top of base event unless events came out of order. Sends an event in any case.
7973
// Should be simplified once events reach from kernel-space to user-space are ordered!
8074
func (gen *ExecFailedGenerator) handleExecFinished(event *trace.Event) (*trace.Event, error) {
81-
defer gen.execEndInfo.Remove(event.HostProcessID)
75+
defer gen.baseEvents.Remove(event.HostProcessID)
8276
execInfo := execEndInfo{
8377
returnCode: event.ReturnValue,
8478
timestamp: event.Timestamp,

0 commit comments

Comments
 (0)