PR #4803: fix(analyze): split input channel

Avoid deadlocks by writing first into a from file channel buffer, then into the engine.

commit d71aff0 (main), cherry-pick

Author: NDStrahilevitz

pkg/analyze/analyze.go

@@ -64,6 +64,7 @@ func Analyze(cfg Config) {
 
 	engineOutput := make(chan *detect.Finding)
 	engineInput := make(chan protocol.Event)
+	fromFile := make(chan protocol.Event)
 
 	source := engine.EventSources{Tracee: engineInput}
 	sigEngine, err := engine.NewEngine(engineConfig, source, engineOutput)
@@ -87,13 +88,18 @@ func Analyze(cfg Config) {
 	}
 
 	// producer
-	go produce(fileReadCtx, stop, cfg.Source, engineInput)
+	go produce(fileReadCtx, stop, cfg.Source, fromFile)
 
 	cfg.Printer.Preamble()
 	defer cfg.Printer.Close()
 	// consumer
 	for {
 		select {
+		case event, ok := <-fromFile:
+			if !ok {
+				return
+			}
+			engineInput <- event
 		case finding, ok := <-engineOutput:
 			if !ok {
 				return
@@ -112,6 +118,11 @@ drain:
 	defer close(engineInput)
 	for {
 		select {
+		case event, ok := <-fromFile:
+			if !ok {
+				return
+			}
+			engineInput <- event
 		case finding, ok := <-engineOutput:
 			if !ok {
 				return