Skip to content

Commit 250647e

Browse files
garypenGeal
authored andcommitted
Use subgraph.name attribute not apollo.subgraph.name (#5012)
The DD exporter does some explicit mapping of attributes and was using a value "apollo.subgraph.name" that the latest versions of the router don't use. The correct choice is "subgraph.name". Update the mapping to reflect this change.
1 parent e8a0045 commit 250647e

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
### Use subgraph.name attribute not apollo.subgraph.name ([PR #5012](https://github.com/apollographql/router/pull/5012))
2+
3+
The Datadog exporter does some explicit mapping of attributes and was using a value "apollo.subgraph.name" that the latest versions of the router don't use. The correct choice is "subgraph.name".
4+
5+
This meant that subgraph name mapping did not work correctly in 1.45.0.
6+
7+
Update the mapping to reflect the change and fix subgraph name mapping for Datadog.
8+
9+
By [@garypen](https://github.com/garypen) in https://github.com/apollographql/router/pull/5012

apollo-router/src/plugins/telemetry/tracing/datadog.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ lazy_static! {
2929
map.insert("request", "http.route");
3030
map.insert("supergraph", "graphql.operation.name");
3131
map.insert("query_planning", "graphql.operation.name");
32-
map.insert("subgraph", "apollo.subgraph.name");
32+
map.insert("subgraph", "subgraph.name");
3333
map.insert("subgraph_request", "graphql.operation.name");
3434
map
3535
};

0 commit comments

Comments
 (0)