@@ -68,7 +68,6 @@ public class ConfigServiceWithCache extends AbstractConfigService {
68
68
private static final String TRACER_EVENT_CACHE_GET_ID = "ConfigCache.GetById" ;
69
69
private static final String TRACER_EVENT_CACHE_LOAD_RELEASE_KEY = "ConfigCache.LoadFromDBByReleaseKey" ;
70
70
71
-
72
71
private final ReleaseService releaseService ;
73
72
private final ReleaseMessageService releaseMessageService ;
74
73
private final BizConfig bizConfig ;
@@ -160,41 +159,41 @@ public void handleMessage(ReleaseMessage message, String channel) {
160
159
}
161
160
162
161
@ Override
163
- public Map <String , Release > findReleasesByReleaseKeys (Set <String > releaseKeys )
164
- {
165
- try {
166
- ImmutableMap <String , Optional <Long >> releaseKeyMap = releaseKeyCache .getAll (releaseKeys );
167
- if (CollectionUtils .isEmpty (releaseKeyMap )) {
168
- return Collections .emptyMap ();
169
- }
170
-
171
- Map <String , Long > validReleaseKeyIdMap = new HashMap <>();
172
- for (Map .Entry <String , Optional <Long >> entry : releaseKeyMap .entrySet ()) {
173
- entry .getValue ().ifPresent (id -> validReleaseKeyIdMap .put (entry .getKey (), id ));
174
- }
175
- if (validReleaseKeyIdMap .isEmpty ()) {
176
- return Collections .emptyMap ();
177
- }
162
+ public Map <String , Release > findReleasesByReleaseKeys (Set <String > releaseKeys ) {
163
+ try {
164
+ ImmutableMap <String , Optional <Long >> releaseKeyMap = releaseKeyCache .getAll (releaseKeys );
165
+ if (CollectionUtils .isEmpty (releaseKeyMap )) {
166
+ return Collections .emptyMap ();
167
+ }
178
168
179
- Map <Long , Optional <Release >> releasesMap = configIdCache .getAll (validReleaseKeyIdMap .values ());
180
- if (CollectionUtils .isEmpty (releasesMap )) {
181
- return Collections .emptyMap ();
182
- }
169
+ Map <String , Long > validReleaseKeyIdMap = new HashMap <>();
170
+ for (Map .Entry <String , Optional <Long >> entry : releaseKeyMap .entrySet ()) {
171
+ entry .getValue ().ifPresent (id -> validReleaseKeyIdMap .put (entry .getKey (), id ));
172
+ }
173
+ if (validReleaseKeyIdMap .isEmpty ()) {
174
+ return Collections .emptyMap ();
175
+ }
183
176
184
- Map <String , Release > releases = new HashMap <>();
185
- for ( Map . Entry < String , Long > entry : validReleaseKeyIdMap .entrySet ()) {
186
- Optional < Release > releaseOpt = releasesMap . get ( entry . getValue ());
187
- releaseOpt . ifPresent ( release -> releases . put ( entry . getKey (), release ) );
188
- }
177
+ Map <Long , Optional < Release >> releasesMap = configIdCache . getAll (
178
+ validReleaseKeyIdMap .values ());
179
+ if ( CollectionUtils . isEmpty ( releasesMap )) {
180
+ return Collections . emptyMap ( );
181
+ }
189
182
190
- return releases .isEmpty () ? Collections .emptyMap () : ImmutableMap .copyOf (releases );
191
- } catch (Exception e ) {
192
- Tracer .logError (e );
193
- logger .error ("Failed to invoke findReleasesByReleaseKeys {}" , releaseKeys , e );
194
- }
195
- return null ;
183
+ Map <String , Release > releases = new HashMap <>();
184
+ for (Map .Entry <String , Long > entry : validReleaseKeyIdMap .entrySet ()) {
185
+ Optional <Release > releaseOpt = releasesMap .get (entry .getValue ());
186
+ releaseOpt .ifPresent (release -> releases .put (entry .getKey (), release ));
196
187
}
197
188
189
+ return releases .isEmpty () ? Collections .emptyMap () : ImmutableMap .copyOf (releases );
190
+ } catch (Exception e ) {
191
+ Tracer .logError (e );
192
+ logger .error ("Failed to invoke findReleasesByReleaseKeys {}" , releaseKeys , e );
193
+ }
194
+ return null ;
195
+ }
196
+
198
197
private void buildConfigCache () {
199
198
CacheBuilder configCacheBuilder = CacheBuilder .newBuilder ()
200
199
.expireAfterAccess (DEFAULT_EXPIRED_AFTER_ACCESS_IN_MINUTES , TimeUnit .MINUTES );
@@ -275,8 +274,8 @@ public Optional<Long> load(String key) throws Exception {
275
274
if (bizConfig .isConfigServiceCacheStatsEnabled ()) {
276
275
GuavaCacheMetrics .monitor (meterRegistry , releaseKeyCache , "releaseKey_cache" );
277
276
}
278
-
279
277
}
278
+
280
279
private void buildConfigIdCache () {
281
280
CacheBuilder configIdCacheBuilder = CacheBuilder .newBuilder ()
282
281
.expireAfterAccess (DEFAULT_EXPIRED_AFTER_ACCESS_IN_MINUTES , TimeUnit .MINUTES );
@@ -286,7 +285,8 @@ private void buildConfigIdCache() {
286
285
configIdCache = configIdCacheBuilder .build (new CacheLoader <Long , Optional <Release >>() {
287
286
@ Override
288
287
public Optional <Release > load (Long key ) throws Exception {
289
- Transaction transaction = Tracer .newTransaction (TRACER_EVENT_CACHE_LOAD_ID , String .valueOf (key ));
288
+ Transaction transaction = Tracer .newTransaction (TRACER_EVENT_CACHE_LOAD_ID ,
289
+ String .valueOf (key ));
290
290
try {
291
291
Release release = releaseService .findActiveOne (key );
292
292
@@ -305,7 +305,6 @@ public Optional<Release> load(Long key) throws Exception {
305
305
if (bizConfig .isConfigServiceCacheStatsEnabled ()) {
306
306
GuavaCacheMetrics .monitor (meterRegistry , configIdCache , "config_id_cache" );
307
307
}
308
-
309
308
}
310
309
311
310
private static class ConfigCacheEntry {
0 commit comments