Skip to content

Commit c061eb9

Browse files
committed
fix some format issue
1 parent b183c44 commit c061eb9

File tree

3 files changed

+37
-45
lines changed

3 files changed

+37
-45
lines changed

apollo-configservice/src/main/java/com/ctrip/framework/apollo/configservice/service/config/ConfigServiceWithCache.java

Lines changed: 33 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ public class ConfigServiceWithCache extends AbstractConfigService {
6868
private static final String TRACER_EVENT_CACHE_GET_ID = "ConfigCache.GetById";
6969
private static final String TRACER_EVENT_CACHE_LOAD_RELEASE_KEY = "ConfigCache.LoadFromDBByReleaseKey";
7070

71-
7271
private final ReleaseService releaseService;
7372
private final ReleaseMessageService releaseMessageService;
7473
private final BizConfig bizConfig;
@@ -160,41 +159,41 @@ public void handleMessage(ReleaseMessage message, String channel) {
160159
}
161160

162161
@Override
163-
public Map<String, Release> findReleasesByReleaseKeys(Set<String> releaseKeys)
164-
{
165-
try {
166-
ImmutableMap<String, Optional<Long>> releaseKeyMap = releaseKeyCache.getAll(releaseKeys);
167-
if (CollectionUtils.isEmpty(releaseKeyMap)) {
168-
return Collections.emptyMap();
169-
}
170-
171-
Map<String, Long> validReleaseKeyIdMap = new HashMap<>();
172-
for (Map.Entry<String, Optional<Long>> entry : releaseKeyMap.entrySet()) {
173-
entry.getValue().ifPresent(id -> validReleaseKeyIdMap.put(entry.getKey(), id));
174-
}
175-
if (validReleaseKeyIdMap.isEmpty()) {
176-
return Collections.emptyMap();
177-
}
162+
public Map<String, Release> findReleasesByReleaseKeys(Set<String> releaseKeys) {
163+
try {
164+
ImmutableMap<String, Optional<Long>> releaseKeyMap = releaseKeyCache.getAll(releaseKeys);
165+
if (CollectionUtils.isEmpty(releaseKeyMap)) {
166+
return Collections.emptyMap();
167+
}
178168

179-
Map<Long, Optional<Release>> releasesMap = configIdCache.getAll(validReleaseKeyIdMap.values());
180-
if (CollectionUtils.isEmpty(releasesMap)) {
181-
return Collections.emptyMap();
182-
}
169+
Map<String, Long> validReleaseKeyIdMap = new HashMap<>();
170+
for (Map.Entry<String, Optional<Long>> entry : releaseKeyMap.entrySet()) {
171+
entry.getValue().ifPresent(id -> validReleaseKeyIdMap.put(entry.getKey(), id));
172+
}
173+
if (validReleaseKeyIdMap.isEmpty()) {
174+
return Collections.emptyMap();
175+
}
183176

184-
Map<String, Release> releases = new HashMap<>();
185-
for (Map.Entry<String, Long> entry : validReleaseKeyIdMap.entrySet()) {
186-
Optional<Release> releaseOpt = releasesMap.get(entry.getValue());
187-
releaseOpt.ifPresent(release -> releases.put(entry.getKey(), release));
188-
}
177+
Map<Long, Optional<Release>> releasesMap = configIdCache.getAll(
178+
validReleaseKeyIdMap.values());
179+
if (CollectionUtils.isEmpty(releasesMap)) {
180+
return Collections.emptyMap();
181+
}
189182

190-
return releases.isEmpty() ? Collections.emptyMap() : ImmutableMap.copyOf(releases);
191-
} catch (Exception e) {
192-
Tracer.logError(e);
193-
logger.error("Failed to invoke findReleasesByReleaseKeys {}", releaseKeys, e);
194-
}
195-
return null;
183+
Map<String, Release> releases = new HashMap<>();
184+
for (Map.Entry<String, Long> entry : validReleaseKeyIdMap.entrySet()) {
185+
Optional<Release> releaseOpt = releasesMap.get(entry.getValue());
186+
releaseOpt.ifPresent(release -> releases.put(entry.getKey(), release));
196187
}
197188

189+
return releases.isEmpty() ? Collections.emptyMap() : ImmutableMap.copyOf(releases);
190+
} catch (Exception e) {
191+
Tracer.logError(e);
192+
logger.error("Failed to invoke findReleasesByReleaseKeys {}", releaseKeys, e);
193+
}
194+
return null;
195+
}
196+
198197
private void buildConfigCache() {
199198
CacheBuilder configCacheBuilder = CacheBuilder.newBuilder()
200199
.expireAfterAccess(DEFAULT_EXPIRED_AFTER_ACCESS_IN_MINUTES, TimeUnit.MINUTES);
@@ -275,8 +274,8 @@ public Optional<Long> load(String key) throws Exception {
275274
if (bizConfig.isConfigServiceCacheStatsEnabled()) {
276275
GuavaCacheMetrics.monitor(meterRegistry, releaseKeyCache, "releaseKey_cache");
277276
}
278-
279277
}
278+
280279
private void buildConfigIdCache() {
281280
CacheBuilder configIdCacheBuilder = CacheBuilder.newBuilder()
282281
.expireAfterAccess(DEFAULT_EXPIRED_AFTER_ACCESS_IN_MINUTES, TimeUnit.MINUTES);
@@ -286,7 +285,8 @@ private void buildConfigIdCache() {
286285
configIdCache = configIdCacheBuilder.build(new CacheLoader<Long, Optional<Release>>() {
287286
@Override
288287
public Optional<Release> load(Long key) throws Exception {
289-
Transaction transaction = Tracer.newTransaction(TRACER_EVENT_CACHE_LOAD_ID, String.valueOf(key));
288+
Transaction transaction = Tracer.newTransaction(TRACER_EVENT_CACHE_LOAD_ID,
289+
String.valueOf(key));
290290
try {
291291
Release release = releaseService.findActiveOne(key);
292292

@@ -305,7 +305,6 @@ public Optional<Release> load(Long key) throws Exception {
305305
if (bizConfig.isConfigServiceCacheStatsEnabled()) {
306306
GuavaCacheMetrics.monitor(meterRegistry, configIdCache, "config_id_cache");
307307
}
308-
309308
}
310309

311310
private static class ConfigCacheEntry {

apollo-configservice/src/main/java/com/ctrip/framework/apollo/configservice/service/config/DefaultIncrementalSyncService.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@
2828
import java.util.Set;
2929
import java.util.concurrent.TimeUnit;
3030

31-
/**
32-
*
33-
*/
3431
public class DefaultIncrementalSyncService implements IncrementalSyncService {
3532

3633
private final Cache<ReleaseKeyPair, List<ConfigurationChange>> configurationChangeCache;
@@ -42,7 +39,6 @@ public DefaultIncrementalSyncService() {
4239
.build();
4340
}
4441

45-
4642
@Override
4743
public List<ConfigurationChange> getConfigurationChanges(String latestMergedReleaseKey,
4844
Map<String, String> latestReleaseConfigurations, String clientSideReleaseKey,
@@ -134,5 +130,4 @@ public int hashCode() {
134130
}
135131
}
136132

137-
138133
}

apollo-configservice/src/main/java/com/ctrip/framework/apollo/configservice/service/config/IncrementalSyncService.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,10 @@
2020
import java.util.List;
2121
import java.util.Map;
2222

23-
24-
/**
25-
* @author jason
26-
*/
2723
public interface IncrementalSyncService {
2824

29-
List<ConfigurationChange> getConfigurationChanges(String latestMergedReleaseKey, Map<String, String> latestReleaseConfigurations, String clientSideReleaseKey, Map<String, String> clientSideConfigurations) ;
25+
List<ConfigurationChange> getConfigurationChanges(String latestMergedReleaseKey,
26+
Map<String, String> latestReleaseConfigurations, String clientSideReleaseKey,
27+
Map<String, String> clientSideConfigurations);
3028

31-
}
29+
}

0 commit comments

Comments
 (0)