-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Pinot API for getting all minions tasks and their summary #17330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krishna-st
wants to merge
4
commits into
apache:master
Choose a base branch
from
krishna-st:minion-task-summary
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,120
−1
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -60,6 +60,7 @@ | |||||
| import org.apache.pinot.controller.util.CompletionServiceHelper; | ||||||
| import org.apache.pinot.core.common.MinionConstants; | ||||||
| import org.apache.pinot.core.minion.PinotTaskConfig; | ||||||
| import org.apache.pinot.spi.config.table.TableConfig; | ||||||
| import org.apache.pinot.spi.ingestion.batch.BatchConfigProperties; | ||||||
| import org.apache.pinot.spi.utils.CommonConstants; | ||||||
| import org.apache.pinot.spi.utils.CommonConstants.Helix; | ||||||
|
|
@@ -83,6 +84,7 @@ public class PinotHelixTaskResourceManager { | |||||
| private static final String TASK_QUEUE_PREFIX = "TaskQueue" + TASK_NAME_SEPARATOR; | ||||||
| private static final String TASK_PREFIX = "Task" + TASK_NAME_SEPARATOR; | ||||||
| private static final String UNKNOWN_TABLE_NAME = "unknown"; | ||||||
| private static final String UNKNOWN_TENANT_NAME = "unknown"; | ||||||
|
|
||||||
| private final TaskDriver _taskDriver; | ||||||
| private final PinotHelixResourceManager _helixResourceManager; | ||||||
|
|
@@ -958,6 +960,142 @@ private boolean hasTasksForTable(String taskName, String tableNameWithType) { | |||||
| } | ||||||
| } | ||||||
|
|
||||||
| /** | ||||||
| * Get the server tenant name for a given table by looking up its configuration. | ||||||
| * Returns "unknown" if the table or tenant cannot be determined. | ||||||
| * | ||||||
| * @param tableName Table name with type (e.g., "myTable_OFFLINE") | ||||||
| * @return Server tenant name or "unknown" | ||||||
| */ | ||||||
| private String getTenantForTable(String tableName) { | ||||||
| if (tableName == null || UNKNOWN_TABLE_NAME.equals(tableName)) { | ||||||
| return UNKNOWN_TENANT_NAME; | ||||||
| } | ||||||
|
|
||||||
| try { | ||||||
| TableConfig tableConfig = _helixResourceManager.getTableConfig(tableName); | ||||||
| if (tableConfig != null && tableConfig.getTenantConfig() != null) { | ||||||
| String serverTenant = tableConfig.getTenantConfig().getServer(); | ||||||
| return serverTenant != null ? serverTenant : UNKNOWN_TENANT_NAME; | ||||||
| } | ||||||
| return UNKNOWN_TENANT_NAME; | ||||||
| } catch (Exception e) { | ||||||
|
||||||
| } catch (Exception e) { | |
| } catch (IllegalStateException | NullPointerException e) { |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constant
UNKNOWN_TENANT_NAMEduplicates the value of the existingCommonConstants.UNKNOWNconstant (imported at line 65). Consider reusingCommonConstants.UNKNOWNto maintain consistency with the existing constantUNKNOWN_TABLE_NAMEon line 86, which uses\"unknown\"but should ideally reference the same shared constant.