Add retry wrapper for Maven steps in workflows #17316
Open
+212
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds retry logic to Maven build and test steps in GitHub Actions workflows to improve CI stability by handling transient Maven errors and flaky tests. The changes wrap existing Maven commands with the nick-fields/retry@v3 action, configured with 3 retry attempts, 20-second wait intervals, and 120-minute timeouts.
Key changes:
- Wraps all Maven-related workflow steps (build, test, linting, compatibility checks) with retry logic
- Applies consistent retry configuration across all affected steps: 3 max attempts, 20s wait between retries, 120min timeout
- Covers three workflow files: main test workflow, multi-stage query engine compatibility tests, and general compatibility tests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/pinot_tests.yml |
Adds retry wrapper to 13 Maven-related steps including dependency installation, linting, builds, unit/integration tests, and report generation |
.github/workflows/pinot_multi_stage_query_engine_compatibility_tests.yml |
Adds retry wrapper to compatibility verifier step |
.github/workflows/pinot_compatibility_tests.yml |
Adds retry wrapper to compatibility verifier step |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17316 +/- ##
============================================
+ Coverage 63.28% 63.29% +0.01%
Complexity 1474 1474
============================================
Files 3135 3135
Lines 186476 186476
Branches 28495 28495
============================================
+ Hits 118003 118039 +36
+ Misses 59360 59322 -38
- Partials 9113 9115 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiangfu0
force-pushed
the
github-action-retry-failure
branch
from
f14e054 to
36ee82b
Compare
xiangfu0
force-pushed
the
github-action-retry-failure
branch
from
36ee82b to
ae649b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope this will improve the CI pass rate for maven transient error and some flaky tests.
Downside is that this may shade some real issue from the flaky tests.