Skip to content

Commit db40bbc

Browse files
committed
Improve error message when query fail while explaining
1 parent fb6955c commit db40bbc

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ExplainIntegrationTestTrait.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ default void explainLogical(@Language("sql") String query, String expected, Map<
4444
.map(entry -> "SET " + entry.getKey() + "=" + entry.getValue() + ";\n")
4545
.collect(Collectors.joining());
4646
JsonNode jsonNode = postQuery(extraOptions + "explain plan without implementation for " + query);
47+
if (!jsonNode.get("exceptions").isNull()) {
48+
Assert.fail("Exception in response: " + jsonNode.get("exceptions").toString());
49+
}
4750
JsonNode plan = jsonNode.get("resultTable").get("rows").get(0).get(1);
4851

4952
Assert.assertEquals(plan.asText(), expected);
@@ -62,6 +65,9 @@ default void explainSse(boolean verbose, @Language("sql") String query, Object..
6265
actualQuery = "SET explainPlanVerbose=true; " + actualQuery;
6366
}
6467
JsonNode jsonNode = postQuery(actualQuery);
68+
if (!jsonNode.get("exceptions").isNull()) {
69+
Assert.fail("Exception in response: " + jsonNode.get("exceptions").toString());
70+
}
6571
JsonNode plan = jsonNode.get("resultTable").get("rows");
6672
List<String> planAsStrList = (List<String>) JsonUtils.jsonNodeToObject(plan, List.class).stream()
6773
.map(Object::toString)
@@ -100,6 +106,9 @@ default void explainSse(@Language("sql") String query, Object... expected) {
100106
default void explain(@Language("sql") String query, String expected) {
101107
try {
102108
JsonNode jsonNode = postQuery("explain plan for " + query);
109+
if (!jsonNode.get("exceptions").isNull()) {
110+
Assert.fail("Exception in response: " + jsonNode.get("exceptions").toString());
111+
}
103112
JsonNode plan = jsonNode.get("resultTable").get("rows").get(0).get(1);
104113

105114
Assert.assertEquals(plan.asText(), expected);

0 commit comments

Comments
 (0)