Adds hex dump length safety check

Author: jon-valliere

mina-core/src/main/java/org/apache/mina/core/buffer/IoBuffer.java

@@ -1545,8 +1545,8 @@ public String getHexDump(int length) {
 	 * @return hexidecimal representation of this buffer
 	 */
 	public String getHexDump(int length, boolean pretty) {
-		return (pretty) ? IoBufferHexDumper.getPrettyHexDumpSlice(this, this.position(), length)
-				: IoBufferHexDumper.getHexDumpSlice(this, this.position(), length);
+		return (pretty) ? IoBufferHexDumper.getPrettyHexDumpSlice(this, this.position(), Math.min(this.remaining(), length))
+				: IoBufferHexDumper.getHexDumpSlice(this, this.position(), Math.min(this.remaining(), length));
 	}
 
 	// //////////////////////////////

mina-core/src/main/java/org/apache/mina/core/buffer/IoBufferHexDumper.java

@@ -20,7 +20,6 @@
 package org.apache.mina.core.buffer;
 
 import java.io.UnsupportedEncodingException;
-import java.nio.charset.StandardCharsets;
 
 /**
  * Provides utility methods to dump an {@link IoBuffer} into a hex formatted

mina-core/src/test/java/org/apache/mina/core/buffer/IoBufferHexDumperTest.java

@@ -16,10 +16,6 @@ public void checkHexDumpLength() {
 
 		buf.flip();
 
-//	System.out.println(buf.getHexDump());
-//	System.out.println(buf.getHexDump(20));
-//	System.out.println(buf.getHexDump(50));
-
 		/* special case */
 		assertEquals(0, buf.getHexDump(0).length());
 
@@ -28,9 +24,9 @@ public void checkHexDumpLength() {
 		assertEquals((Math.min(300, buf.limit()) * 3) - 1, buf.getHexDump(300).length());
 
 		/* must truncate */
-		assertEquals((7 * 3) + 2, buf.getHexDump(7).length());
-		assertEquals((10 * 3) + 2, buf.getHexDump(10).length());
-		assertEquals((30 * 3) + 2, buf.getHexDump(30).length());
+		assertEquals((7 * 3) - 1, buf.getHexDump(7).length());
+		assertEquals((10 * 3) - 1, buf.getHexDump(10).length());
+		assertEquals((30 * 3) - 1, buf.getHexDump(30).length());
 
 	}
 
@@ -44,15 +40,7 @@ public void checkPrettyHexDumpLength() {
 
 		buf.flip();
 
-//		System.out.println(buf.getHexDump(0, true));
-//		System.out.println(buf.getHexDump(20, true));
-//		System.out.println(buf.getHexDump(50, true));
-
 		String[] dump = buf.getHexDump(50, true).split("\\n");
-
-		for (String x : dump) {
-			System.out.println(x);
-		}
 
 		assertEquals(4, dump.length);
 	}