Skip to content

Commit 614241f

Browse files
committed
Fix rerun and skip IT
Signed-off-by: Olivier Lamy <[email protected]>
1 parent 6c411b7 commit 614241f

File tree

7 files changed

+18
-28
lines changed

7 files changed

+18
-28
lines changed

surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1202RerunAndSkipIT.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
import org.apache.maven.surefire.its.fixture.SurefireLauncher;
2323
import org.junit.Test;
2424

25+
import static org.apache.maven.surefire.its.fixture.HelperAssertions.assumeJavaVersion;
26+
2527
/**
2628
* Allow rerunFailingTestsCount, skipAfterFailureCount together
2729
*
@@ -33,7 +35,8 @@ public class Surefire1202RerunAndSkipIT extends SurefireJUnitIntegrationTestCase
3335

3436
@Test
3537
public void junit4() {
36-
unpack().addGoal("-Pjunit4").executeTest().assertTestSuiteResults(5, 0, 0, 3, 4);
38+
assumeJavaVersion(17);
39+
unpack().executeTest().assertTestSuiteResults(5, 0, 0, 3, 4);
3740
}
3841

3942
private SurefireLauncher unpack() {

surefire-its/src/test/resources/surefire-1202-rerun-and-failfast/pom.xml

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,15 @@
4545
<maven.compiler.target>1.8</maven.compiler.target>
4646
</properties>
4747

48+
<dependencies>
49+
<dependency>
50+
<groupId>org.junit.jupiter</groupId>
51+
<artifactId>junit-jupiter-api</artifactId>
52+
<version>6.0.1</version>
53+
<scope>test</scope>
54+
</dependency>
55+
</dependencies>
56+
4857
<build>
4958
<pluginManagement>
5059
<plugins>
@@ -63,26 +72,4 @@
6372
</pluginManagement>
6473
</build>
6574

66-
<profiles>
67-
<profile>
68-
<id>junit4</id>
69-
<dependencies>
70-
<dependency>
71-
<groupId>junit</groupId>
72-
<artifactId>junit</artifactId>
73-
<version>4.12</version>
74-
<scope>test</scope>
75-
</dependency>
76-
</dependencies>
77-
<build>
78-
<plugins>
79-
<plugin>
80-
<groupId>org.apache.maven.plugins</groupId>
81-
<artifactId>maven-surefire-plugin</artifactId>
82-
</plugin>
83-
</plugins>
84-
</build>
85-
</profile>
86-
</profiles>
87-
8875
</project>

surefire-its/src/test/resources/surefire-1202-rerun-and-failfast/src/test/java/pkg/ATest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package pkg;
22

3-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
44

55
import static java.util.concurrent.TimeUnit.MILLISECONDS;
66
import static java.util.concurrent.TimeUnit.SECONDS;

surefire-its/src/test/resources/surefire-1202-rerun-and-failfast/src/test/java/pkg/BTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package pkg;
22

3-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
44

55
import static java.util.concurrent.TimeUnit.SECONDS;
66

surefire-its/src/test/resources/surefire-1202-rerun-and-failfast/src/test/java/pkg/CTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package pkg;
22

3-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
44

55
import static java.util.concurrent.TimeUnit.MILLISECONDS;
66

surefire-its/src/test/resources/surefire-1202-rerun-and-failfast/src/test/java/pkg/DTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package pkg;
22

3-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
44

55
import static java.util.concurrent.TimeUnit.MILLISECONDS;
66

surefire-its/src/test/resources/surefire-1202-rerun-and-failfast/src/test/java/pkg/ETest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package pkg;
22

3-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
44

55
public class ETest
66
{

0 commit comments

Comments
 (0)