Reduce non-debug logging (#389)

* Reduce non-debug logging

Author: elharo

src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java

@@ -3436,7 +3436,7 @@ private String getJavadocExecutable() throws IOException {
         //
         // In Java 9 and above the JRE is no longer in a subdirectory of the
         // JDK, i.e. the JRE and the JDK are merged. In this case the java
-        // command is installed to my-dir/bin/java along side the javadoc
+        // command is installed to my-dir/bin/java alongside the javadoc
         // command. So the relative path from "java.home" to the javadoc
         // command is bin/javadoc.
         //
@@ -3451,8 +3451,9 @@ private String getJavadocExecutable() throws IOException {
         // "JEP 220: Modular Run-Time Images"
         // http://openjdk.java.net/jeps/220
         // ----------------------------------------------------------------------
-        // For IBM's JDK 1.2
         // CHECKSTYLE_ON: LineLength
+
+        // For IBM's JDK 1.2
         if (SystemUtils.IS_OS_AIX) {
             javadocExe =
                     new File(SystemUtils.getJavaHome() + File.separator + ".." + File.separator + "sh", javadocCommand);
@@ -3930,7 +3931,7 @@ private void copyAdditionalJavadocResources(File anOutputDirectory) throws Maven
             selectors[0].setExcludes(new String[] {"META-INF/**"});
             unArchiver.setFileSelectors(selectors);
 
-            getLog().info("Extracting contents of resources artifact: " + artifact.getArtifactId());
+            getLog().debug("Extracting contents of resources artifact: " + artifact.getArtifactId());
             try {
                 unArchiver.extract();
             } catch (ArchiverException e) {
@@ -5009,13 +5010,13 @@ private boolean isUpToDate(Commandline cmd) throws MavenReportException {
                 prvdata = null;
             }
             if (curdata.equals(prvdata)) {
-                getLog().info("Skipping javadoc generation, everything is up to date.");
+                getLog().debug("Skipping javadoc generation, everything is up to date.");
                 return true;
             } else {
                 if (prvdata == null) {
-                    getLog().info("No previous run data found, generating javadoc.");
+                    getLog().debug("No previous run data found, generating javadoc.");
                 } else {
-                    getLog().info("Configuration changed, re-generating javadoc.");
+                    getLog().debug("Configuration changed, re-generating javadoc.");
                     if (getLog().isDebugEnabled()) {
                         List<String> newStrings = new ArrayList<>(curdata);
                         List<String> remStrings = new ArrayList<>(prvdata);
@@ -5365,14 +5366,13 @@ private List<OfflineLink> getModulesLinks() throws MavenReportException {
             File location = new File(p.getBasedir(), javadocDirRelative);
 
             if (!location.exists()) {
+                String javadocGoal = getFullJavadocGoal();
                 if (getLog().isDebugEnabled()) {
                     getLog().debug("Javadoc directory not found: " + location);
+                    getLog().debug("The goal '" + javadocGoal + "' has not been previously called for the module: '"
+                            + p.getId() + "'. Trying to invoke it...");
                 }
 
-                String javadocGoal = getFullJavadocGoal();
-                getLog().info("The goal '" + javadocGoal + "' has not been previously called for the module: '"
-                        + p.getId() + "'. Trying to invoke it...");
-
                 File invokerDir = new File(project.getBuild().getDirectory(), "invoker");
                 invokerDir.mkdirs();
                 File invokerLogFile = FileUtils.createTempFile("maven-javadoc-plugin", ".txt", invokerDir);

src/main/java/org/apache/maven/plugins/javadoc/JavadocJarMojo.java

@@ -270,7 +270,7 @@ private File generateArchive(File javadocFiles, String jarFileName) throws Archi
         }
 
         if (useDefaultManifestFile && defaultManifestFile.exists() && archive.getManifestFile() == null) {
-            getLog().info("Adding existing MANIFEST to archive. Found under: " + defaultManifestFile.getPath());
+            getLog().debug("Adding existing MANIFEST to archive. Found under: " + defaultManifestFile.getPath());
             archive.setManifestFile(defaultManifestFile);
         }
 

src/test/java/org/apache/maven/plugins/javadoc/JavadocJarMojoTest.java

@@ -192,13 +192,13 @@ public void testStale() throws Exception {
 
         new File(getBasedir(), "target/test/unit/stale-test/target/maven-javadoc-plugin-stale-data.txt").delete();
         mojo.execute();
-        assertThat(log.getMessages()).contains("[INFO] No previous run data found, generating javadoc.");
+        assertThat(log.getMessages()).contains("[DEBUG] No previous run data found, generating javadoc.");
 
         Thread.sleep(500);
 
         log.getMessages().clear();
         mojo.execute();
-        assertThat(log.getMessages()).contains("[INFO] Skipping javadoc generation, everything is up to date.");
+        assertThat(log.getMessages()).contains("[DEBUG] Skipping javadoc generation, everything is up to date.");
     }
 
     private static class BufferingLog implements Log {