Skip to content

Commit 809bfe1

Browse files
committed
[MDEP-494] Remove/replace Maven2 specific code
Core ArtifactResolver not used anymore git-svn-id: https://svn.apache.org/repos/asf/maven/plugins/trunk@1688075 13f79535-47bb-0310-9956-ffa450edef68
1 parent 173b7b4 commit 809bfe1

File tree

7 files changed

+7
-54
lines changed

7 files changed

+7
-54
lines changed

src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import org.apache.maven.artifact.factory.ArtifactFactory;
2929
import org.apache.maven.artifact.metadata.ArtifactMetadataSource;
3030
import org.apache.maven.artifact.repository.ArtifactRepository;
31-
import org.apache.maven.artifact.resolver.ArtifactResolver;
3231
import org.apache.maven.execution.MavenSession;
3332
import org.apache.maven.plugin.AbstractMojo;
3433
import org.apache.maven.plugin.MojoExecutionException;
@@ -61,12 +60,6 @@ public abstract class AbstractDependencyMojo
6160
@Component
6261
protected ArtifactFactory factory;
6362

64-
/**
65-
* Used to look up Artifacts in the remote repository.
66-
*/
67-
@Component
68-
protected ArtifactResolver resolver;
69-
7063
/**
7164
*
7265
*/
@@ -400,22 +393,6 @@ public void setRemoteRepos( List<ArtifactRepository> remoteRepos )
400393
this.remoteRepos = remoteRepos;
401394
}
402395

403-
/**
404-
* @return Returns the resolver.
405-
*/
406-
public ArtifactResolver getResolver()
407-
{
408-
return this.resolver;
409-
}
410-
411-
/**
412-
* @param resolver The resolver to set.
413-
*/
414-
public void setResolver( ArtifactResolver resolver )
415-
{
416-
this.resolver = resolver;
417-
}
418-
419396
/**
420397
* @param archiverManager The archiverManager to set.
421398
*/

src/test/java/org/apache/maven/plugin/dependency/AbstractDependencyMojoTestCase.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import java.io.File;
2323
import java.io.IOException;
2424

25-
import org.apache.maven.artifact.resolver.ArtifactResolver;
2625
import org.apache.maven.plugin.MojoExecutionException;
2726
import org.apache.maven.plugin.dependency.testUtils.DependencyArtifactStubFactory;
2827
import org.apache.maven.plugin.dependency.testUtils.DependencyTestUtils;
@@ -83,11 +82,6 @@ protected void tearDown()
8382
stubFactory = null;
8483
}
8584

86-
protected void setResolver( AbstractDependencyMojo mojo, ArtifactResolver resolver )
87-
{
88-
mojo.resolver = resolver;
89-
}
90-
9185
protected void setSilent( AbstractDependencyMojo mojo, boolean silent )
9286
{
9387
mojo.silent = silent;

src/test/java/org/apache/maven/plugin/dependency/fromConfiguration/TestCopyMojo.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import org.apache.maven.plugin.dependency.testUtils.DependencyTestUtils;
3535
import org.apache.maven.plugin.dependency.utils.DependencyUtil;
3636
import org.apache.maven.plugin.testing.stubs.StubArtifactRepository;
37-
import org.apache.maven.plugin.testing.stubs.StubArtifactResolver;
3837
import org.apache.maven.project.MavenProject;
3938
import org.sonatype.aether.impl.internal.SimpleLocalRepositoryManager;
4039
import org.sonatype.aether.util.DefaultRepositorySystemSession;
@@ -68,7 +67,6 @@ protected void setUp()
6867
// MavenProject project = mojo.getProject();
6968
// init classifier things
7069
mojo.setFactory( DependencyTestUtils.getArtifactFactory() );
71-
mojo.setResolver( new StubArtifactResolver( stubFactory, false, false ) );
7270

7371
MavenSession session = newMavenSession( mojo.getProject() );
7472
setVariableValueToObject( mojo, "session", session );
@@ -564,7 +562,6 @@ public void dotestArtifactExceptions( boolean are, boolean anfe )
564562

565563
// init classifier things
566564
mojo.setFactory( DependencyTestUtils.getArtifactFactory() );
567-
mojo.setResolver( new StubArtifactResolver( null, are, anfe ) );
568565
mojo.setLocal( new StubArtifactRepository( this.testDir.getAbsolutePath() ) );
569566

570567
try

src/test/java/org/apache/maven/plugin/dependency/fromConfiguration/TestIncludeExcludeUnpackMojo.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import org.apache.maven.plugin.dependency.utils.markers.UnpackFileMarkerHandler;
3535
import org.apache.maven.plugin.testing.ArtifactStubFactory;
3636
import org.apache.maven.plugin.testing.stubs.StubArtifactRepository;
37-
import org.apache.maven.plugin.testing.stubs.StubArtifactResolver;
3837
import org.codehaus.plexus.archiver.manager.ArchiverManager;
3938
import org.sonatype.aether.RepositorySystem;
4039
import org.sonatype.aether.util.DefaultRepositorySystemSession;
@@ -78,7 +77,6 @@ protected void setUp()
7877
mojo.setArchiverManager( (ArchiverManager) lookup( ArchiverManager.ROLE ) );
7978

8079
mojo.setFactory( DependencyTestUtils.getArtifactFactory() );
81-
mojo.setResolver( new StubArtifactResolver( stubFactory, false, false ) );
8280
mojo.setMarkersDirectory( new File( this.testDir, "markers" ) );
8381
mojo.setArtifactItems( list );
8482

src/test/java/org/apache/maven/plugin/dependency/fromConfiguration/TestUnpackMojo.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
import org.apache.maven.plugin.dependency.utils.markers.UnpackFileMarkerHandler;
4141
import org.apache.maven.plugin.testing.ArtifactStubFactory;
4242
import org.apache.maven.plugin.testing.stubs.StubArtifactRepository;
43-
import org.apache.maven.plugin.testing.stubs.StubArtifactResolver;
4443
import org.apache.maven.project.MavenProject;
4544
import org.sonatype.aether.RepositorySystem;
4645
import org.sonatype.aether.util.DefaultRepositorySystemSession;
@@ -79,8 +78,6 @@ protected void setUp()
7978
+ "target/test-classes/unit/unpack-dependencies-test/test.txt" ) );
8079

8180
mojo.setFactory( DependencyTestUtils.getArtifactFactory() );
82-
mojo.setResolver( new StubArtifactResolver( stubFactory, false, false ) );
83-
// mojo.setLocal( new StubArtifactRepository( this.testDir.getAbsolutePath() ) );
8481
mojo.setUseJvmChmod( true );
8582

8683
MavenSession session = newMavenSession( mojo.getProject() );
@@ -404,7 +401,6 @@ public void dotestArtifactExceptions( boolean are, boolean anfe )
404401

405402
// init classifier things
406403
mojo.setFactory( DependencyTestUtils.getArtifactFactory() );
407-
mojo.setResolver( new StubArtifactResolver( null, are, anfe ) );
408404
mojo.setLocal( new StubArtifactRepository( this.testDir.getAbsolutePath() ) );
409405

410406
try

src/test/java/org/apache/maven/plugin/dependency/fromDependencies/TestCopyDependenciesMojo.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,9 @@
3737
import org.apache.maven.plugin.dependency.utils.markers.DefaultFileMarkerHandler;
3838
import org.apache.maven.plugin.testing.ArtifactStubFactory;
3939
import org.apache.maven.plugin.testing.stubs.StubArtifactRepository;
40-
import org.apache.maven.plugin.testing.stubs.StubArtifactResolver;
4140
import org.apache.maven.project.MavenProject;
4241
import org.codehaus.plexus.util.StringUtils;
4342
import org.sonatype.aether.RepositorySystem;
44-
import org.sonatype.aether.repository.LocalRepositoryManager;
4543
import org.sonatype.aether.util.DefaultRepositorySystemSession;
4644

4745
public class TestCopyDependenciesMojo
@@ -470,7 +468,6 @@ public void dotestClassifierType( String testClassifier, String testType )
470468

471469
// init classifier things
472470
mojo.setFactory( DependencyTestUtils.getArtifactFactory() );
473-
mojo.setResolver( new StubArtifactResolver( stubFactory, false, false ) );
474471

475472
mojo.execute();
476473

@@ -522,7 +519,6 @@ public void dotestArtifactExceptions( boolean are, boolean anfe )
522519

523520
// init classifier things
524521
mojo.setFactory( DependencyTestUtils.getArtifactFactory() );
525-
setResolver( mojo, new StubArtifactResolver( null, are, anfe ) );
526522
mojo.setLocal( new StubArtifactRepository( this.testDir.getAbsolutePath() ) );
527523

528524
try
@@ -789,7 +785,6 @@ public void testCopyPom()
789785
throws Exception
790786
{
791787
mojo.setCopyPom( true );
792-
mojo.setResolver( new StubArtifactResolver( stubFactory, false, false ) );
793788
mojo.setLocal( new StubArtifactRepository( this.testDir.getAbsolutePath() ) );
794789

795790
Set<Artifact> set = new HashSet<Artifact>();

src/test/java/org/apache/maven/plugin/dependency/fromDependencies/TestUnpackDependenciesMojo.java

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -19,34 +19,32 @@
1919
* under the License.
2020
*/
2121

22-
import org.apache.maven.plugin.MojoFailureException;
22+
import java.io.File;
23+
import java.io.IOException;
24+
import java.util.HashSet;
25+
import java.util.Iterator;
26+
import java.util.Set;
27+
2328
import org.apache.maven.artifact.Artifact;
2429
import org.apache.maven.artifact.repository.ArtifactRepository;
2530
import org.apache.maven.artifact.repository.LegacyLocalRepositoryManager;
2631
import org.apache.maven.artifact.resolver.filter.ScopeArtifactFilter;
2732
import org.apache.maven.artifact.versioning.VersionRange;
2833
import org.apache.maven.execution.MavenSession;
2934
import org.apache.maven.plugin.MojoExecutionException;
35+
import org.apache.maven.plugin.MojoFailureException;
3036
import org.apache.maven.plugin.dependency.AbstractDependencyMojoTestCase;
31-
import org.apache.maven.plugin.dependency.fromDependencies.UnpackDependenciesMojo;
3237
import org.apache.maven.plugin.dependency.testUtils.DependencyArtifactStubFactory;
3338
import org.apache.maven.plugin.dependency.testUtils.DependencyTestUtils;
3439
import org.apache.maven.plugin.dependency.utils.DependencyUtil;
3540
import org.apache.maven.plugin.dependency.utils.markers.DefaultFileMarkerHandler;
3641
import org.apache.maven.plugin.testing.ArtifactStubFactory;
3742
import org.apache.maven.plugin.testing.stubs.StubArtifactRepository;
38-
import org.apache.maven.plugin.testing.stubs.StubArtifactResolver;
3943
import org.apache.maven.project.MavenProject;
4044
import org.codehaus.plexus.util.StringUtils;
4145
import org.sonatype.aether.RepositorySystem;
4246
import org.sonatype.aether.util.DefaultRepositorySystemSession;
4347

44-
import java.io.File;
45-
import java.io.IOException;
46-
import java.util.HashSet;
47-
import java.util.Iterator;
48-
import java.util.Set;
49-
5048
public class TestUnpackDependenciesMojo
5149
extends AbstractDependencyMojoTestCase
5250
{
@@ -537,7 +535,6 @@ public void dotestClassifierType( String testClassifier, String testType )
537535
mojo.classifier = testClassifier;
538536
mojo.type = testType;
539537
mojo.setFactory( DependencyTestUtils.getArtifactFactory() );
540-
mojo.setResolver( new StubArtifactResolver( stubFactory, false, false ) );
541538

542539
for (Artifact artifact : mojo.getProject().getArtifacts())
543540
{
@@ -586,7 +583,6 @@ public void dotestArtifactExceptions( boolean are, boolean anfe )
586583
mojo.type = "java-sources";
587584
// init classifier things
588585
mojo.setFactory( DependencyTestUtils.getArtifactFactory() );
589-
mojo.setResolver( new StubArtifactResolver( null, are, anfe ) );
590586
mojo.setLocal( new StubArtifactRepository( this.testDir.getAbsolutePath() ) );
591587

592588
try

0 commit comments

Comments
 (0)