Change BOM activation and stop managing dependencies #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
requested changes
Oct 10, 2024
Contributor
ppkarwasz
left a comment
ppkarwasz
left a comment
There was a problem hiding this comment.
Looks good to me, except we could remove the parent of the POMs.
That makes me wonder if we can omit <pomElements> and use the defaults.
Member
Author
@ppkarwasz, I prefer not to – it keeps |
ppkarwasz
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements following changes
flatten-bomexecution offlatten-maven-pluginusing a.logging-parent-bom-activatorfilebiz.aQute.bnd:biz.aQute.bnd.annotationcom.github.spotbugs:spotbugs-annotationsorg.jspecify:jspecifyorg.osgi:osgi.annotationorg.osgi:org.osgi.annotation.bundleorg.osgi:org.osgi.annotation.versioningThe removal of managed dependencies fixes apache/logging-log4j2#3066.