[Android] check dup exception report for every instance (#2226)

[Android] add IConfigAdapter && check repeat report

Author: lucky-chen

android/sdk/src/main/java/com/taobao/weex/WXSDKManager.java

@@ -26,6 +26,7 @@
 import com.taobao.weex.adapter.ClassLoaderAdapter;
 import com.taobao.weex.adapter.DefaultUriAdapter;
 import com.taobao.weex.adapter.DefaultWXHttpAdapter;
+import com.taobao.weex.adapter.IWXConfigAdapter;
 import com.taobao.weex.adapter.ICrashInfoReporter;
 import com.taobao.weex.adapter.IDrawableLoader;
 import com.taobao.weex.adapter.IWXJscProcessManager;
@@ -90,6 +91,7 @@ public class WXSDKManager {
 
   private IWXJSExceptionAdapter mIWXJSExceptionAdapter;
 
+  private IWXConfigAdapter mConfigAdapter;
   private IWXStorageAdapter mIWXStorageAdapter;
   private IWXStatisticsListener mStatisticsListener;
   private URIAdapter mURIAdapter;
@@ -218,6 +220,14 @@ public WXWorkThreadManager getWXWorkThreadManager() {
     return mWXWorkThreadManager;
   }
 
+  public void setWxConfigAdapter(IWXConfigAdapter mConfigAdapter) {
+    this.mConfigAdapter = mConfigAdapter;
+  }
+
+  public IWXConfigAdapter getWxConfigAdapter() {
+    return mConfigAdapter;
+  }
+
   public @Nullable WXSDKInstance getSDKInstance(String instanceId) {
     return instanceId == null? null : mWXRenderManager.getWXSDKInstance(instanceId);
   }

android/sdk/src/main/java/com/taobao/weex/adapter/IWXConfigAdapter.java

@@ -0,0 +1,9 @@
+package com.taobao.weex.adapter;
+
+/**
+ * @author zhongcang
+ * @date 2019/3/20
+ */
+public interface IWXConfigAdapter {
+    String getConfig(String nameSpace,String key,String defaultValue);
+}

android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java

@@ -1469,7 +1469,14 @@ private void invokeCreateInstance(@NonNull WXSDKInstance instance, Script templa
             } else {
               options.put(BUNDLE_TYPE, "Others");
             }
-            instance.getApmForInstance().addProperty(WXInstanceApm.KEY_PAGE_PROPERTIES_BUNDLE_TYPE, options.get(BUNDLE_TYPE));
+            Object recordBundleType = options.get(BUNDLE_TYPE);
+            if (recordBundleType instanceof String && "Others".equalsIgnoreCase((String)recordBundleType)){
+              //same as iOS record
+              recordBundleType = "other";
+            }
+            if (null != recordBundleType){
+              instance.getApmForInstance().addProperty(WXInstanceApm.KEY_PAGE_PROPERTIES_BUNDLE_TYPE, recordBundleType);
+            }
           }
           if (options.get("env") == null) {
             options.put("env", mInitParams.toMap());

android/sdk/src/main/java/com/taobao/weex/performance/WXInstanceApm.java

@@ -20,7 +20,9 @@
 
 import java.util.HashMap;
 import java.util.Map;
+import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.CopyOnWriteArraySet;
 
 import android.graphics.Rect;
 import android.os.Handler;
@@ -133,6 +135,8 @@ public class WXInstanceApm {
     public boolean hasAddView;
     private Handler mUIHandler;
 
+    public Set<String> exceptionRecord = new CopyOnWriteArraySet<String>();
+
     /**
      * send performance value to js
      **/
@@ -302,6 +306,7 @@ public void onEnd() {
         if (null == apmInstance || mEnd) {
             return;
         }
+        exceptionRecord.clear();
         mUIHandler.removeCallbacks(jsPerformanceCallBack);
         onStage(KEY_PAGE_STAGES_DESTROY);
         apmInstance.onEnd();

android/sdk/src/main/java/com/taobao/weex/utils/WXExceptionUtils.java

@@ -25,14 +25,18 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
+import java.util.Set;
+import java.util.concurrent.CopyOnWriteArraySet;
 
 import android.support.annotation.Nullable;
 import android.text.TextUtils;
 import com.taobao.weex.WXEnvironment;
 import com.taobao.weex.WXSDKInstance;
 import com.taobao.weex.WXSDKManager;
+import com.taobao.weex.adapter.IWXConfigAdapter;
 import com.taobao.weex.adapter.IWXJSExceptionAdapter;
 import com.taobao.weex.common.WXErrorCode;
+import com.taobao.weex.common.WXErrorCode.ErrorGroup;
 import com.taobao.weex.common.WXJSExceptionInfo;
 import com.taobao.weex.common.WXPerformance;
 import com.taobao.weex.performance.WXAnalyzerDataTransfer;
@@ -44,11 +48,50 @@
 
 public class WXExceptionUtils {
 
+    private static Set<String> sGlobalExceptionRecord = new CopyOnWriteArraySet<String>();
+
 	/**
 	 * degradeUrl for degrade case
 	 */
 	public static String degradeUrl = "BundleUrlDefaultDegradeUrl";
 
+	private static boolean checkNeedReportCauseRepeat(String instanceId,WXErrorCode errCode,String exception){
+
+	    if (TextUtils.isEmpty(exception)){
+	        return true;
+        }
+
+        if (null != errCode && errCode.getErrorGroup() != ErrorGroup.JS){
+	        return true;
+        }
+
+        if (TextUtils.isEmpty(instanceId)){
+            instanceId = "instanceIdNull";
+        }
+
+        String targetException = exception.length() > 200 ?exception.substring(0,200) : exception;
+        Set<String> recordExceptionHistory= null;
+
+        WXSDKInstance instance =  WXSDKManager.getInstance().getAllInstanceMap().get(instanceId);
+        if (null == instance){
+            recordExceptionHistory = sGlobalExceptionRecord;
+        }else {
+            recordExceptionHistory =  instance.getApmForInstance().exceptionRecord;
+        }
+
+        if (null == recordExceptionHistory){
+            return true;
+        }
+
+        if (recordExceptionHistory.contains(targetException)){
+            return false;
+        }
+        recordExceptionHistory.add(targetException);
+        return true;
+    }
+
+
+
 
 	/**
 	 * commitCriticalExceptionRT eg:JsRuntime Exception or JsFramework Init Exception
@@ -63,6 +106,26 @@ public static void commitCriticalExceptionRT(@Nullable final String instanceId,
 												 @Nullable final String function,
 												 @Nullable final String exception,
 												 @Nullable final Map<String,String> extParams ) {
+
+        try {
+            IWXConfigAdapter configAdapter = WXSDKManager.getInstance().getWxConfigAdapter();
+            boolean doCheck = true;
+            if (null != configAdapter){
+                String value = configAdapter.getConfig("wxapm","check_repeat_report","true");
+                doCheck = "true".equalsIgnoreCase(value);
+            }
+            boolean doReport =true;
+            if (doCheck){
+                doReport = checkNeedReportCauseRepeat(instanceId,errCode,exception);
+            }
+            if (!doReport){
+                return;
+            }
+        }catch (Throwable e){
+            e.printStackTrace();
+        }
+
+
 		commitCriticalExceptionWithDefaultUrl(
 		    "BundleUrlDefault",
             instanceId,