Skip to content
This repository was archived by the owner on Jun 3, 2021. It is now read-only.

Commit cbfb57b

Browse files
YorkShenlucky-chen
authored andcommitted
[Android] Remove duplicate receiver in manifest and remove final from class definition. (#2879)
* [Manifest demo](http://dotwe.org/vue/3351b6b69cac58d852ce0aef43d8eb85), work as before. * [globalEvent](https://weex.apache.org/docs/modules/globalEvent.html#globalevent)
1 parent 72b0bdb commit cbfb57b

File tree

3 files changed

+19
-13
lines changed

3 files changed

+19
-13
lines changed

android/sdk/src/main/AndroidManifest.xml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,4 @@ under the License.
2020
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
2121
package="com.taobao.weex">
2222
<uses-permission android:name="android.permission.READ_PHONE_STATE"/>
23-
24-
<application>
25-
<receiver
26-
android:name="com.taobao.weex.WXGlobalEventReceiver"
27-
android:enabled="true"
28-
android:exported="false">
29-
</receiver>
30-
31-
32-
</application>
3323
</manifest>

android/sdk/src/main/java/com/taobao/weex/common/WXWorkThreadManager.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,21 @@
1818
*/
1919
package com.taobao.weex.common;
2020

21+
import android.support.annotation.RestrictTo;
22+
import android.support.annotation.RestrictTo.Scope;
2123
import java.util.concurrent.ExecutorService;
2224
import java.util.concurrent.Executors;
2325

2426
/**
25-
* Class for managing work thread
27+
* Class for managing work thread.
28+
*
29+
* <p>
30+
* This class is for internal purpose,
31+
* please don't use it directly unless you know what you are doing.
32+
* </p>
2633
*/
27-
public final class WXWorkThreadManager {
34+
@RestrictTo(Scope.LIBRARY_GROUP)
35+
public class WXWorkThreadManager {
2836

2937
private ExecutorService singleThreadExecutor;
3038

android/sdk/src/main/java/com/taobao/weex/ui/module/WXDomModule.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
*/
1919
package com.taobao.weex.ui.module;
2020

21+
import android.support.annotation.RestrictTo;
22+
import android.support.annotation.RestrictTo.Scope;
2123
import com.alibaba.fastjson.JSONArray;
2224
import com.alibaba.fastjson.JSONObject;
2325
import com.taobao.weex.WXSDKInstance;
@@ -41,8 +43,14 @@
4143
* <p>
4244
* This module is work different with other regular module, method is invoked directly, without reflection.
4345
* </p>
46+
*
47+
* <p>
48+
* This class is for internal purpose,
49+
* please don't use it directly unless you know what you are doing.
50+
* </p>
4451
*/
45-
public final class WXDomModule extends WXModule {
52+
@RestrictTo(Scope.LIBRARY_GROUP)
53+
public class WXDomModule extends WXModule {
4654

4755
/** package **/
4856
public static final String SCROLL_TO_ELEMENT = "scrollToElement";

0 commit comments

Comments
 (0)