-
Notifications
You must be signed in to change notification settings - Fork 8.9k
bugfix: fix undo_log id repeat #4985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 29 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
e9e7255
release 0.5.1
slievrly f017c6b
release 0.5.2
slievrly 7ca3332
Release 0.6.0 (#1106)
zhangthen dc088cb
Revert "Release 0.6.0 (#1106)" (#1107)
slievrly da96029
re-merging 0.6.0
slievrly ca567ef
Release 0.6.1
zhangthen 1b90f93
release 0.7.0
slievrly 39e4d89
release 0.7.1
slievrly 0945681
release 0.8.0
slievrly 9ffa290
release 0.8.1
slievrly a174ed5
release 0.9.0
slievrly 5bdbc44
[release] release 1.0.0
slievrly f990a57
release: release 1.1.0
slievrly 04d0568
Merge pull request #2582 from seata/1.2.0
slievrly 2e2a424
release: release 1.3.0
slievrly f270a2d
Merge pull request #3252 from seata/1.4.0
slievrly ce86bdc
change version to 1.4.1
slievrly fcc74e7
Merge remote-tracking branch 'upstream/develop' into 1.4.1
slievrly 9569bed
release: release 1.4.1
slievrly f8359f0
[release]: release for 1.4.1
slievrly 8bd92a5
Merge branch 'master' into 1.4.2
slievrly 5ddfbc1
[release]: release for 1.4.2
slievrly 1c22e62
optimize: some tiny fixes in release 1.5.0 (#4611)
slievrly be9c3eb
Merge branch 'master' into 1.5.0
slievrly 3d26425
doc: update change.md (#4612) (#4613)
slievrly ede95ef
Merge pull request #4610 from seata/1.5.0
slievrly 46d75f3
optimize: fix conflicts
slievrly c95d49f
Merge pull request #4771 from seata/1.5.2
slievrly d5f30f8
bugfix: fix undo_log `id` repeat
whxxxxx 699a1dd
Merge branch 'develop' into hotfix_field_distinct
funky-eyes 51a965a
bugfix: fix undo_log `id` repeat
whxxxxx e9172fd
bugfix: Use methods that in ColumnUtils
whxxxxx 025955b
bugfix: modify ColumnUtils,KeywordChecker,KeywordCheckerFactory route
whxxxxx 79cb474
bugfix: insert test case
whxxxxx ac308e2
bugfix: insert test case
whxxxxx 0952519
Merge branch 'develop' into hotfix_field_distinct
slievrly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,6 +91,9 @@ private String buildBeforeImageSQL(TableMeta tableMeta, ArrayList<List<Object>> | |
| suffix.append(" FOR UPDATE"); | ||
| StringJoiner selectSQLJoin = new StringJoiner(", ", prefix.toString(), suffix.toString()); | ||
| if (ONLY_CARE_UPDATE_COLUMNS) { | ||
| for (String updateColumn : updateColumns) { | ||
|
||
| org.apache.commons.lang.StringUtils.replace(updateColumn, "`", ""); | ||
| } | ||
| if (!containsPK(updateColumns)) { | ||
| selectSQLJoin.add(getColumnNamesInSQL(tableMeta.getEscapePkNameList(getDbType()))); | ||
| } | ||
|
|
@@ -137,6 +140,9 @@ private String buildAfterImageSQL(TableMeta tableMeta, TableRecords beforeImage) | |
| if (ONLY_CARE_UPDATE_COLUMNS) { | ||
| SQLUpdateRecognizer recognizer = (SQLUpdateRecognizer) sqlRecognizer; | ||
| List<String> updateColumns = recognizer.getUpdateColumns(); | ||
| for (String updateColumn : updateColumns) { | ||
| org.apache.commons.lang.StringUtils.replace(updateColumn, "`", ""); | ||
| } | ||
| if (!containsPK(updateColumns)) { | ||
| selectSQLJoiner.add(getColumnNamesInSQL(tableMeta.getEscapePkNameList(getDbType()))); | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.