-
Notifications
You must be signed in to change notification settings - Fork 8.9k
optimize: mysql 8.0.29 not should be hold for connection #4765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request introduces 1 alert when merging 00a29a3 into 708f97f - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 50d75ef into 708f97f - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 4dd94eb into 708f97f - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## develop #4765 +/- ##
=============================================
- Coverage 48.65% 48.63% -0.02%
- Complexity 4069 4075 +6
=============================================
Files 736 736
Lines 25683 25721 +38
Branches 3170 3177 +7
=============================================
+ Hits 12495 12510 +15
- Misses 11847 11867 +20
- Partials 1341 1344 +3
|
|
This pull request introduces 1 alert when merging dd9ef73 into 708f97f - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 4134e8e into 708f97f - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 3d80ec4 into 63ec93a - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This pull request introduces 1 alert when merging 9ce7f3a into d979af4 - view on LGTM.com new alerts:
|
Ⅰ. Describe what this PR did
1.mysql8.0.29允许不同的连接进行二阶段的行为,因此在此版本下无需持有连接至二阶段
mariadb经测试无法如此,所以必须和低版本的mysql一致处理
2.抽离xa兜底断开物理连接的线程池构建,只有在需要hold连接至二阶段的哪些datasource存在在进行构建线程池和任务运行
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews