Skip to content

Conversation

@funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Jul 10, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

1.mysql8.0.29允许不同的连接进行二阶段的行为,因此在此版本下无需持有连接至二阶段
mariadb经测试无法如此,所以必须和低版本的mysql一致处理
2.抽离xa兜底断开物理连接的线程池构建,只有在需要hold连接至二阶段的哪些datasource存在在进行构建线程池和任务运行

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@lgtm-com
Copy link

lgtm-com bot commented Jul 10, 2022

This pull request introduces 1 alert when merging 00a29a3 into 708f97f - view on LGTM.com

new alerts:

  • 1 for Race condition in double-checked locking object initialization

@lgtm-com
Copy link

lgtm-com bot commented Jul 10, 2022

This pull request introduces 1 alert when merging 50d75ef into 708f97f - view on LGTM.com

new alerts:

  • 1 for Race condition in double-checked locking object initialization

@lgtm-com
Copy link

lgtm-com bot commented Jul 11, 2022

This pull request introduces 1 alert when merging 4dd94eb into 708f97f - view on LGTM.com

new alerts:

  • 1 for Race condition in double-checked locking object initialization

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #4765 (944fd13) into develop (3b607c2) will decrease coverage by 0.01%.
The diff coverage is 33.87%.

❗ Current head 944fd13 differs from pull request most recent head 6b011f1. Consider uploading reports for the commit 6b011f1 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4765      +/-   ##
=============================================
- Coverage      48.65%   48.63%   -0.02%     
- Complexity      4069     4075       +6     
=============================================
  Files            736      736              
  Lines          25683    25721      +38     
  Branches        3170     3177       +7     
=============================================
+ Hits           12495    12510      +15     
- Misses         11847    11867      +20     
- Partials        1341     1344       +3     
Impacted Files Coverage Δ
.../src/main/java/io/seata/core/protocol/Version.java 8.33% <ø> (ø)
...a/io/seata/rm/datasource/xa/ResourceManagerXA.java 8.95% <3.44%> (-5.60%) ⬇️
...a/io/seata/rm/datasource/xa/ConnectionProxyXA.java 56.05% <50.00%> (+0.20%) ⬆️
...a/io/seata/rm/datasource/xa/DataSourceProxyXA.java 73.33% <57.89%> (-11.29%) ⬇️
.../main/java/io/seata/rm/BaseDataSourceResource.java 31.81% <100.00%> (+4.39%) ⬆️
...asource/sql/struct/cache/OracleTableMetaCache.java 65.68% <0.00%> (-0.99%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
...erver/storage/file/session/FileSessionManager.java 48.40% <0.00%> (+0.63%) ⬆️
.../java/io/seata/spring/util/TCCBeanParserUtils.java 32.25% <0.00%> (+1.61%) ⬆️

@lgtm-com
Copy link

lgtm-com bot commented Jul 11, 2022

This pull request introduces 1 alert when merging dd9ef73 into 708f97f - view on LGTM.com

new alerts:

  • 1 for Race condition in double-checked locking object initialization

@funky-eyes funky-eyes requested review from sharajava and slievrly July 11, 2022 05:36
@lgtm-com
Copy link

lgtm-com bot commented Jul 11, 2022

This pull request introduces 1 alert when merging 4134e8e into 708f97f - view on LGTM.com

new alerts:

  • 1 for Race condition in double-checked locking object initialization

@funky-eyes funky-eyes added this to the 2.0.0 milestone Jul 11, 2022
@funky-eyes funky-eyes modified the milestones: 2.0.0, 1.6.0 Jul 16, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jul 16, 2022

This pull request introduces 1 alert when merging 3d80ec4 into 63ec93a - view on LGTM.com

new alerts:

  • 1 for Race condition in double-checked locking object initialization

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit a4b266c into apache:develop Jul 21, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jul 21, 2022

This pull request introduces 1 alert when merging 9ce7f3a into d979af4 - view on LGTM.com

new alerts:

  • 1 for Race condition in double-checked locking object initialization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants