Fixes Invalid Proxy exception when using a SSL client without Proxy

Cédric Tabin · ok2c · commit 6d60624cd343 · 2023-11-23T14:09:34.000+01:00
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/ssl/SSLConnectionSocketFactory.java b/httpclient5/src/main/java/org/apache/hc/client5/http/ssl/SSLConnectionSocketFactory.java
@@ -206,7 +206,7 @@ public Socket createSocket(final HttpContext context) throws IOException {
 
     @Override
     public Socket createSocket(final Proxy proxy, final HttpContext context) throws IOException {
-        return new Socket(proxy);
+        return proxy != null ? new Socket(proxy) : new Socket();
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ public Socket createSocket(final HttpContext context) throws IOException {`
`206`	`206`
`207`	`207`	`@Override`
`208`	`208`	`public Socket createSocket(final Proxy proxy, final HttpContext context) throws IOException {`
`209`		`- return new Socket(proxy);`
	`209`	`+ return proxy != null ? new Socket(proxy) : new Socket();`
`210`	`210`	`}`
`211`	`211`
`212`	`212`	`@Override`