Skip to content

Commit e23a407

Browse files
committed
fix: detectValue & parseDataValue not crashing with BigInt
1 parent 697e798 commit e23a407

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/data/helper/dataValueHelper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export function parseDataValue(
6767
? NaN
6868
// If string (like '-'), using '+' parse to NaN
6969
// If object, also parse to NaN
70-
: +value;
70+
: Number(value);
7171
};
7272

7373

src/data/helper/sourceHelper.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -449,8 +449,8 @@ function doGuessOrdinal(
449449
function detectValue(val: OptionDataValue): BeOrdinalValue {
450450
const beStr = isString(val);
451451
// Consider usage convenience, '1', '2' will be treated as "number".
452-
// `isFinit('')` get `true`.
453-
if (val != null && isFinite(val as number) && val !== '') {
452+
// `Number('')` (or any whitespace) is `0`.
453+
if (val != null && Number.isFinite(Number(val)) && val !== '') {
454454
return beStr ? BE_ORDINAL.Might : BE_ORDINAL.Not;
455455
}
456456
else if (beStr && val !== '-') {

0 commit comments

Comments
 (0)