don't applyCustomizeException in not grpc node

Author: oxsean

dubbo-rpc/dubbo-rpc-triple/pom.xml

@@ -196,6 +196,13 @@
       <plugin>
         <groupId>org.codehaus.gmavenplus</groupId>
         <artifactId>gmavenplus-plugin</artifactId>
+        <executions>
+          <execution>
+            <goals>
+              <goal>compileTests</goal>
+            </goals>
+          </execution>
+        </executions>
       </plugin>
     </plugins>
   </build>

dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/UnaryServerCallListener.java

@@ -24,14 +24,14 @@
 
 public class UnaryServerCallListener extends AbstractServerCallListener {
 
-    private boolean applyCustomizeException = false;
+    private final boolean applyCustomizeException;
 
     public UnaryServerCallListener(
-            RpcInvocation invocation, Invoker<?> invoker, StreamObserver<Object> responseObserver) {
+            RpcInvocation invocation,
+            Invoker<?> invoker,
+            StreamObserver<Object> responseObserver,
+            boolean applyCustomizeException) {
         super(invocation, invoker, responseObserver);
-    }
-
-    public void setApplyCustomizeException(boolean applyCustomizeException) {
         this.applyCustomizeException = applyCustomizeException;
     }
 

dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/grpc/GrpcHttp2ServerTransportListener.java

@@ -34,6 +34,7 @@
 import org.apache.dubbo.rpc.TriRpcStatus;
 import org.apache.dubbo.rpc.model.FrameworkModel;
 import org.apache.dubbo.rpc.protocol.tri.DescriptorUtils;
+import org.apache.dubbo.rpc.protocol.tri.ReflectionPackableMethod;
 import org.apache.dubbo.rpc.protocol.tri.RpcInvocationBuildContext;
 import org.apache.dubbo.rpc.protocol.tri.compressor.DeCompressor;
 import org.apache.dubbo.rpc.protocol.tri.compressor.Identity;
@@ -138,6 +139,19 @@ protected GrpcStreamingDecoder getStreamingDecoder() {
         return (GrpcStreamingDecoder) super.getStreamingDecoder();
     }
 
+    @Override
+    protected boolean applyCustomizeException() {
+        RpcInvocationBuildContext context = getContext();
+        if (context.isHasStub()) {
+            return false;
+        }
+        MethodMetadata methodMetadata = context.getMethodMetadata();
+        return ReflectionPackableMethod.needWrap(
+                context.getMethodDescriptor(),
+                methodMetadata.getActualRequestTypes(),
+                methodMetadata.getActualResponseType());
+    }
+
     private class LazyFindMethodListener implements HttpMessageListener {
 
         private final StreamingDecoder streamingDecoder;

dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http1/DefaultHttp11ServerTransportListener.java

@@ -126,7 +126,7 @@ private static class AutoCompleteUnaryServerCallListener extends UnaryServerCall
 
         public AutoCompleteUnaryServerCallListener(
                 RpcInvocation invocation, Invoker<?> invoker, StreamObserver<Object> responseObserver) {
-            super(invocation, invoker, responseObserver);
+            super(invocation, invoker, responseObserver, false);
         }
 
         @Override

dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http2/GenericHttp2ServerTransportListener.java

@@ -29,7 +29,6 @@
 import org.apache.dubbo.remoting.http12.message.DefaultListeningDecoder;
 import org.apache.dubbo.remoting.http12.message.DefaultStreamingDecoder;
 import org.apache.dubbo.remoting.http12.message.ListeningDecoder;
-import org.apache.dubbo.remoting.http12.message.MethodMetadata;
 import org.apache.dubbo.remoting.http12.message.StreamingDecoder;
 import org.apache.dubbo.remoting.http12.message.codec.JsonCodec;
 import org.apache.dubbo.rpc.CancellationContext;
@@ -39,7 +38,6 @@
 import org.apache.dubbo.rpc.executor.ExecutorSupport;
 import org.apache.dubbo.rpc.model.FrameworkModel;
 import org.apache.dubbo.rpc.model.MethodDescriptor;
-import org.apache.dubbo.rpc.protocol.tri.ReflectionPackableMethod;
 import org.apache.dubbo.rpc.protocol.tri.RpcInvocationBuildContext;
 import org.apache.dubbo.rpc.protocol.tri.TripleProtocol;
 import org.apache.dubbo.rpc.protocol.tri.h12.AbstractServerTransportListener;
@@ -109,19 +107,8 @@ private ServerCallListener startListener(
         switch (methodDescriptor.getRpcType()) {
             case UNARY:
                 onUnary();
-                boolean applyCustomizeException = false;
-                if (!getContext().isHasStub()) {
-                    MethodMetadata methodMetadata = getContext().getMethodMetadata();
-                    applyCustomizeException = ReflectionPackableMethod.needWrap(
-                            methodDescriptor,
-                            methodMetadata.getActualRequestTypes(),
-                            methodMetadata.getActualResponseType());
-                }
                 onListenerStart();
-                UnaryServerCallListener unaryServerCallListener =
-                        startUnary(invocation, invoker, getServerChannelObserver());
-                unaryServerCallListener.setApplyCustomizeException(applyCustomizeException);
-                return unaryServerCallListener;
+                return startUnary(invocation, invoker, getServerChannelObserver());
             case SERVER_STREAM:
                 onListenerStart();
                 return startServerStreaming(invocation, invoker, getServerChannelObserver());
@@ -147,7 +134,7 @@ protected void onListenerStart() {
 
     private UnaryServerCallListener startUnary(
             RpcInvocation invocation, Invoker<?> invoker, Http2ServerChannelObserver responseObserver) {
-        return new UnaryServerCallListener(invocation, invoker, responseObserver);
+        return new UnaryServerCallListener(invocation, invoker, responseObserver, applyCustomizeException());
     }
 
     private ServerStreamServerCallListener startServerStreaming(
@@ -216,6 +203,10 @@ protected final Http2ServerChannelObserver getServerChannelObserver() {
         return serverChannelObserver;
     }
 
+    protected boolean applyCustomizeException() {
+        return false;
+    }
+
     @Override
     public void close() throws Exception {
         getServerChannelObserver().close();