Skip to content

Commit 3e1310b

Browse files
authored
Fix TriRpcStatus not implements Serializable (#13453)
* Fix TriRpcStatus not implements Serializable * Fix TriRpcStatus not implements Serializable
1 parent 58fa120 commit 3e1310b

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/TriRpcStatus.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
import org.apache.dubbo.common.utils.StringUtils;
2020
import org.apache.dubbo.remoting.TimeoutException;
2121

22+
import java.io.Serializable;
23+
2224
import io.netty.handler.codec.http.HttpResponseStatus;
2325
import io.netty.handler.codec.http.QueryStringDecoder;
2426
import io.netty.handler.codec.http.QueryStringEncoder;
@@ -35,7 +37,7 @@
3537
/**
3638
* See https://github.com/grpc/grpc/blob/master/doc/statuscodes.md
3739
*/
38-
public class TriRpcStatus {
40+
public class TriRpcStatus implements Serializable {
3941

4042
public static final TriRpcStatus OK = fromCode(Code.OK);
4143
public static final TriRpcStatus UNKNOWN = fromCode(Code.UNKNOWN);

dubbo-rpc/dubbo-rpc-triple/src/test/java/org/apache/dubbo/rpc/TriRpcStatusTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
import org.apache.dubbo.remoting.TimeoutException;
2020
import org.apache.dubbo.rpc.TriRpcStatus.Code;
2121

22+
import java.io.Serializable;
23+
2224
import io.netty.handler.codec.http.HttpResponseStatus;
2325
import org.junit.jupiter.api.Assertions;
2426
import org.junit.jupiter.api.Test;
@@ -214,4 +216,11 @@ void triCodeToDubboCode() {
214216
Assertions.assertEquals(METHOD_NOT_FOUND, TriRpcStatus.triCodeToDubboCode(Code.UNIMPLEMENTED));
215217
Assertions.assertEquals(UNKNOWN_EXCEPTION, TriRpcStatus.triCodeToDubboCode(Code.UNKNOWN));
216218
}
219+
220+
@Test
221+
void testSerializable() {
222+
TriRpcStatus status = TriRpcStatus.INTERNAL.withDescription("test");
223+
Assertions.assertInstanceOf(Serializable.class, status.asException());
224+
Assertions.assertInstanceOf(Serializable.class, status.asException().getStatus());
225+
}
217226
}

0 commit comments

Comments
 (0)