Skip to content

Conversation

@oil-oil
Copy link
Contributor

@oil-oil oil-oil commented Feb 18, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Add rejected_msg field to limit-count plugin form.
image

Related issues

fix #2094

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Copy link
Contributor

@zaunist zaunist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@oil-oil
Copy link
Contributor Author

oil-oil commented Feb 21, 2022

@bzp2010 Please help me review this pr, thank.

@codecov-commenter
Copy link

Codecov Report

Merging #2328 (3fc4658) into master (46c56f4) will increase coverage by 3.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2328      +/-   ##
==========================================
+ Coverage   64.65%   68.17%   +3.52%     
==========================================
  Files         184      127      -57     
  Lines        7280     3375    -3905     
  Branches      830      830              
==========================================
- Hits         4707     2301    -2406     
+ Misses       2290     1074    -1216     
+ Partials      283        0     -283     
Flag Coverage Δ
backend-e2e-test ?
backend-unit-test ?
frontend-e2e-test 68.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/UI/limit-count.tsx 88.09% <ø> (ø)
api/internal/core/migrate/conflict.go
api/internal/core/store/store_mock.go
api/internal/utils/pid.go
api/internal/core/entity/format.go
api/internal/core/storage/etcd.go
api/internal/utils/version.go
api/internal/core/server/server.go
api/internal/handler/proto/proto.go
api/internal/core/entity/interface.go
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c56f4...3fc4658. Read the comment docs.

@bzp2010 bzp2010 requested review from LiteSun and juzhiyuan February 27, 2022 08:25
@juzhiyuan juzhiyuan merged commit 6d2445e into apache:master Feb 27, 2022
hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request Mar 13, 2022
* origin:
  chore: Create route form optimization (apache#2336)
  fix: add rejected_msg field to limit-count plugin form (apache#2328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: limit-* plugin UI form support reject-message field

8 participants