DROID-4080 make membership/tiers update async #2844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the membership provider to support force-refreshing membership status and tiers, and implements a reactive system for tier updates through event observation. The changes enable the UI to immediately refresh membership data after critical user actions like purchases or email verification.
- Added
forceRefreshparameter toMembershipProvider.status()to bypass cache when needed - Implemented
observeTiers()channel to reactively observe tier updates from server events - Integrated force refresh mechanism in
MembershipViewModeltriggered by purchases and email verification
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| MembershipProvider.kt | Added forceRefresh parameter and implemented reactive tier observation through combine() |
| MembershipViewModel.kt | Added forceRefreshTrigger flow to trigger cache bypass after purchases and email verification |
| MembershipMiddlewareChannel.kt | Implemented observeTiers() to listen for membership tier update events |
| MembershipChannel.kt | Added observeTiers() interface method to support tier event observation |
| MembershipRemoteChannel.kt | Added observeTiers() interface and delegate implementation in MembershipDateChannel |
| MembershipModels.kt | Added MembershipTiers.Event data class to represent tier update events |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
payments/src/main/java/com/anytypeio/anytype/payments/viewmodel/MembershipViewModel.kt
Show resolved
Hide resolved
payments/src/main/java/com/anytypeio/anytype/payments/viewmodel/MembershipViewModel.kt
Show resolved
Hide resolved
...n/src/main/java/com/anytypeio/anytype/presentation/membership/provider/MembershipProvider.kt
Outdated
Show resolved
Hide resolved
…ata-fetching-refactoring-integration-android # Conflicts: # presentation/src/main/java/com/anytypeio/anytype/presentation/membership/provider/MembershipProvider.kt
konstantiniiv
deleted the
droid-4080-membership-data-fetching-refactoring-integration-android
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.