code review, use ANVIL_HOSTS everywhere

Author: manggit

python_anvil/api_resources/requests.py

@@ -2,6 +2,8 @@
 
 from python_anvil.http import HTTPClient
 
+from constants import VALID_HOSTS
+
 
 class AnvilRequest:
     show_headers = False
@@ -166,18 +168,13 @@ def get_url(self):
 class FullyQualifiedRequest(BaseAnvilHttpRequest):
     """A request class that validates URLs point to Anvil domains."""
 
-    VALID_HOSTS = [
-        "https://app.useanvil.com",
-        # Future Anvil specific URLs
-    ]
-
     def get_url(self):
         return ""  # Not used since we expect full URLs
 
     def _validate_url(self, url):
-        if not any(url.startswith(host) for host in self.VALID_HOSTS):
+        if not any(url.startswith(host) for host in VALID_HOSTS):
             raise ValueError(
-                f"URL must start with one of: {', '.join(self.VALID_HOSTS)}"
+                f"URL must start with one of: {', '.join(VALID_HOSTS)}"
             )
 
     def get(self, url, params=None, **kwargs):

python_anvil/constants.py

@@ -1,7 +1,14 @@
 """Basic constants used in the library."""
 
 GRAPHQL_ENDPOINT: str = "https://graphql.useanvil.com"
-REST_ENDPOINT = "https://app.useanvil.com/api/v1/"
+REST_ENDPOINT = "https://app.useanvil.com/api/v1"
+ANVIL_HOST = "https://app.useanvil.com"
+
+VALID_HOSTS = [
+    ANVIL_HOST,
+    REST_ENDPOINT,
+    GRAPHQL_ENDPOINT,
+]
 
 RETRIES_LIMIT = 5
 REQUESTS_LIMIT = {

python_anvil/tests/test_api.py

@@ -12,6 +12,7 @@
 
 from ..api_resources.payload import FillPDFPayload
 from . import payloads
+from constants import VALID_HOSTS
 
 
 DEV_KEY = "MY-SECRET-KEY"
@@ -403,7 +404,7 @@ def describe_rest_request_absolute_url_behavior():
             [
                 ("some/relative/path", True),
                 ("https://external.example.com/full/path/file.pdf", True),
-                ("https://app.useanvil.com/api/v1/some-endpoint", False),
+                *[(host + "/some-endpoint", False) for host in VALID_HOSTS],
             ],
         )
         @mock.patch("python_anvil.api_resources.requests.AnvilRequest._request")
@@ -431,7 +432,7 @@ def test_get_behavior(mock_request, anvil, url, should_raise):
             [
                 ("some/relative/path", True),
                 ("https://external.example.com/full/path/file.pdf", True),
-                ("https://app.useanvil.com/api/v1/some-endpoint", False),
+                *[(host + "/some-endpoint", False) for host in VALID_HOSTS],
             ],
         )
         @mock.patch("python_anvil.api_resources.requests.AnvilRequest._request")