v2.1.0

[newhouse]

Description of the change

yarn version

Type of change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

• The code changed/added as part of this pull request has been covered with tests
• All tests related to the changed code pass in development
• No previous tests unrelated to the changed code fail in development

Code review

• This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
• At least one reviewer has been requested
• Changes have been reviewed by at least one other engineer
• The relevant project board has been selected in Projects to auto-link to this pull request

[newhouse]

Also @benogle can you or @ralbayaty invite/add me to our Org on npm.js? Username is newhouse...but the e-mail is my personal one.

[benogle]

You have been invited

[newhouse]

Thanks @benogle I'm in!. If you think this looks good, plz approve and I will merge and publish on npm

[ralbayaty]

The changelog in here seems to squash out the v2.0.0. Not sure if this has anything to do with having not done yarn publish in awhile in here (last published package seems to be v1.0.2).Suppose it isn't the end of the world.

[newhouse]

The changelog in here seems to squash out the v2.0.0. Not sure if this has anything to do with having not done yarn publish in awhile in here (last published package seems to be v1.0.2).Suppose it isn't the end of the world.

Are the changes still in the repo @ralbayaty ? I'm not a fan of this version autocreate thing...

If they're in there, I may just go along with things how they are...nbd.

[ralbayaty]

Are the changes still in the repo @ralbayaty ? I'm not a fan of this version autocreate thing...

Yeah looks like it only squashed the versions together in the changelog but the commits are still in there.

The changelog autocreate stuff was a swift thing I put in to help devs see what has changed without adding any overhead to us.

yarn version is meant to be run inline during a yarn publish (or npm publish, I forget which one we use here) off of master, and not in a PR directly. So basically in master branch we yarn publish which bumps the version, updates the changelog, then pushes the package to the registry. This is how lerna publish works in (without the changelog) a monorepo we have.

If they're in there, I may just go along with things how they are...nbd.

I think we should do this all off master and nix this PR. If things don't work as intended we can change the flow to whatever you think is easier from a dev standpoint and document it better (this should have already been done to avoid confusion).

[newhouse]

I think we should do this all off master and nix this PR. If things don't work as intended we can change the flow to whatever you think is easier from a dev standpoint and document it better (this should have already been done to avoid confusion).

I tried to do it off of master, but could not. Git(hub) complained when pushing that a reviewer needed to approve it, or that I can't push straight to master or something...

[ralbayaty]

I tried to do it off of master, but could not. Git(hub) complained when pushing that a reviewer needed to approve it, or that I can't push straight to master or something...

No bueno. In that case, go ahead with whatever gets your stuff in and feel free to change whatever you need to make this easiest. It would be great to have a low/no maintenance CHANGELOG, but if not currently feasible we can nix it for time being.