-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add support c++ target on android #2248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
should fix #2247 |
| Either open the included XCode project and build that or use the cmake compilation as described for linux. | ||
|
|
||
| #### Compiling on Android | ||
| Try run cmake -DCMAKE_ANDROID_NDK=/folder/of/android_ndkr17_and_above -DCMAKE_SYSTEM_NAME=Android -DCMAKE_ANDROID_API=14 -DCMAKE_ANDROID_ARCH_ABI=x86 -DCMAKE_ANDROID_STL_TYPE=c++_shared -DCMAKE_ANDROID_NDK_TOOLCHAIN_VERSION=clang -DCMAKE_BUILD_TYPE=Release /folder/antlr4_src_dir -G Ninja. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a line break after the header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think something like html end break tag , or just inserting single new line (enter command)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uvguy Just a line break (), otherwise the heading markup might not be recognized correctly.
|
@uvguy Add yourself to the contributors.txt file, if you haven't already. |
|
Apologize for late reply, I still have another busy week yesterday and I'm still learning git on how to make proper pull request from command line right now. Is there easy github button to edit patch or do I have to clone my fork and create new branch from there and submit a new pull request? |
|
You have your clone, right? And you have checked it out locally on your box. Now change the file and commit that. This change will automatically be added to your pull request (provided you use the same branch you used for this PR). |
|
Yes I have, but from this commit I use simple git push button from my fork of master branch. uvguy@bb516f0 . |
|
@uvguy If you want this patch to get into the next release please resolve the contributors.txt file (probably just needs a merge from antlr4 master to your branch). |
these change simply add target platform android.