Skip to content

Conversation

@uvguy
Copy link
Contributor

@uvguy uvguy commented Mar 10, 2018

these change simply add target platform android.

@uvguy
Copy link
Contributor Author

uvguy commented Mar 10, 2018

should fix #2247

Either open the included XCode project and build that or use the cmake compilation as described for linux.

#### Compiling on Android
Try run cmake -DCMAKE_ANDROID_NDK=/folder/of/android_ndkr17_and_above -DCMAKE_SYSTEM_NAME=Android -DCMAKE_ANDROID_API=14 -DCMAKE_ANDROID_ARCH_ABI=x86 -DCMAKE_ANDROID_STL_TYPE=c++_shared -DCMAKE_ANDROID_NDK_TOOLCHAIN_VERSION=clang -DCMAKE_BUILD_TYPE=Release /folder/antlr4_src_dir -G Ninja.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line break after the header.

Copy link
Contributor Author

@uvguy uvguy Mar 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think something like html end break tag , or just inserting single new line (enter command)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uvguy Just a line break (), otherwise the heading markup might not be recognized correctly.

@mike-lischke
Copy link
Member

@uvguy Add yourself to the contributors.txt file, if you haven't already.

@uvguy
Copy link
Contributor Author

uvguy commented Mar 12, 2018

Apologize for late reply, I still have another busy week yesterday and I'm still learning git on how to make proper pull request from command line right now. Is there easy github button to edit patch or do I have to clone my fork and create new branch from there and submit a new pull request?

@mike-lischke
Copy link
Member

You have your clone, right? And you have checked it out locally on your box. Now change the file and commit that. This change will automatically be added to your pull request (provided you use the same branch you used for this PR).

@uvguy
Copy link
Contributor Author

uvguy commented Mar 12, 2018

Yes I have, but from this commit I use simple git push button from my fork of master branch. uvguy@bb516f0 .

@mike-lischke
Copy link
Member

@uvguy If you want this patch to get into the next release please resolve the contributors.txt file (probably just needs a merge from antlr4 master to your branch).

@parrt parrt added this to the 4.7.2 milestone Nov 11, 2018
@parrt parrt merged commit 2159d15 into antlr:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants