C++ runtime: Fix two issues found by coverity #1951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have an alternate fix for the IntervalSet va_end problem in pull request #1930 that eliminates va_arg usage and replaces it with a variadic template. I don't think @mike-lischke has had a chance to review it yet, though. |
Member
|
@jm-mikkelsen I reviewed that patch already. |
Contributor
Author
|
@jm-mikkelsen Not a problem. I'll rebase this one if yours gets merged sooner. |
mike-lischke
approved these changes
Jul 29, 2017
Member
|
weAlso need a signature in the contributors file... |
Member
|
@Griffon26 We need a signature in the contributors file before I can merge this. |
Contributor
Author
|
Man you're fast! I was in the process of rebasing to master =D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tiny changes to fix two coverity violations that I encountered while checking my own codebase.