Skip to content

Commit f2ee752

Browse files
authored
Merge pull request #1848 from davesisson/master
Fix tests for PR #1844.
2 parents c1663e7 + e9dd953 commit f2ee752

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

doc/go-target.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ func (this *TreeShapeListener) EnterEveryRule(ctx antlr.ParserRuleContext) {
8888
}
8989
9090
func main() {
91-
input := antlr.NewFileStream(os.Args[1])
91+
input, _ := antlr.NewFileStream(os.Args[1])
9292
lexer := parser.NewJSONLexer(input)
9393
stream := antlr.NewCommonTokenStream(lexer,0)
9494
p := parser.NewJSONParser(stream)

runtime-testsuite/test/org/antlr/v4/test/runtime/go/BaseGoTest.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -674,6 +674,7 @@ protected void writeParserTestFile(String parserName, String lexerName,
674674
"import (\n"
675675
+" \"github.com/antlr/antlr4/runtime/Go/antlr\"\n"
676676
+" \"./parser\"\n"
677+
+" \"fmt\"\n"
677678
+" \"os\"\n"
678679
+")\n"
679680
+ "\n"
@@ -696,7 +697,11 @@ protected void writeParserTestFile(String parserName, String lexerName,
696697
+ "}\n"
697698
+ "\n"
698699
+ "func main() {\n"
699-
+ " input := antlr.NewFileStream(os.Args[1])\n"
700+
+ " input, err := antlr.NewFileStream(os.Args[1])\n"
701+
+ " if err != nil {\n"
702+
+ " fmt.Printf(\"Failed to find file: %v\", err)\n"
703+
+ " return\n"
704+
+ " }\n"
700705
+ " lexer := parser.New<lexerName>(input)\n"
701706
+ " stream := antlr.NewCommonTokenStream(lexer,0)\n"
702707
+ "<createParser>"
@@ -734,7 +739,11 @@ protected void writeLexerTestFile(String lexerName, boolean showDFA) {
734739
+ ")\n"
735740
+ "\n"
736741
+ "func main() {\n"
737-
+ " input := antlr.NewFileStream(os.Args[1])\n"
742+
+ " input, err := antlr.NewFileStream(os.Args[1])\n"
743+
+ " if err != nil {\n"
744+
+ " fmt.Printf(\"Failed to find file: %v\", err)\n"
745+
+ " return\n"
746+
+ " }\n"
738747
+ " lexer := parser.New<lexerName>(input)\n"
739748
+ " stream := antlr.NewCommonTokenStream(lexer,0)\n"
740749
+ " stream.Fill()\n"

runtime/Go/antlr/file_stream.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ func NewFileStream(fileName string) (*FileStream, error) {
2828
return nil, err
2929
}
3030
defer f.Close()
31-
err = io.Copy(buf, f)
31+
_, err = io.Copy(buf, f)
3232
if err != nil {
33-
return nil, er
33+
return nil, err
3434
}
3535

3636
fs := new(FileStream)

0 commit comments

Comments
 (0)