Added ZCU102 version for the AD9467 #2957

JRabacca · 2025-09-25T05:52:15Z

PR Description

Created a new dts and dtsi files for the AD9467 on the ZCU102. The files were based on the Zedboard versions. They were then modified to match the needs of ZCU102. This included additional i2c and system info nodes and changes to base addresses.
To be merged together with the HDL PR analogdevicesinc/hdl#1924

PR Type

Bug fix (a change that fixes an issue)
New feature (a change that adds new functionality)
Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

I have conducted a self-review of my own code changes
I have tested the changes on the relevant hardware
I have updated the documentation outside this repo accordingly (if there is the case)

nunojsa

Hi,

Thanks for your contribution. Some comments though:

Please don't do merge commits;
Use proper commit subjects (following the kernel style)

Having the above in mind, please:

Rebase the branch onto main to remove merge commits
Use git log --oneline on the relevant directories to see proper commit message examples (suggestion below):

arm64: dts: xilinx: add AD9467 support for ZCU102
arm64: defconfig: add AD9467 firmware files

nunojsa · 2025-10-02T12:27:45Z

arch/arm64/boot/dts/xilinx/adi-ad9467-fmc-250ebz.dtsi

+};
+
+&fmc_spi {
+   status = "okay";


Wrong indentation. Please use tabs

Changed to tab in c19b6e4

nunojsa · 2025-10-02T12:28:05Z

arch/arm64/boot/dts/xilinx/adi-ad9467-fmc-250ebz.dtsi

+		spi-max-frequency = <10000000>;
+		adi,spi-3wire-enable;
+
+		// clocks = <&clk_ad9517 3>;


Drop commented lines unless there's a good reason to keep them

Removed in c19b6e4

JRabacca · 2025-10-03T03:12:36Z

Hi

I rebased the commits, reworded the commit subjects, and changed the spaces to tabs. Unfortunately, I messed up somewhere and the commits that were previously authored and push by other people are appearing as a commit on mine.
Would it be preferable to just redo this whole thing from scratch and start a new pull request? I don't mind since the number of files I actually edited are small.

nunojsa · 2025-10-28T16:34:20Z

I rebased the commits, reworded the commit subjects, and changed the spaces to tabs. Unfortunately, I messed up somewhere and the commits that were previously authored and push by other people are appearing as a commit on mine.
Would it be preferable to just redo this whole thing from scratch and start a new pull request? I don't mind since the number of files I actually edited are small.

@JRabacca, if you prefer. But it should be easy to get this fixed... Anyways, whatever easier for you :)

JRabacca · 2025-11-06T09:44:29Z

I've reset it then rebased it to squash my commits.

nunojsa

Just some last minute things I noticed

nunojsa · 2025-11-06T13:25:55Z

arch/arm64/boot/dts/xilinx/adi-ad9467-fmc-250ebz.dtsi

@@ -0,0 +1,50 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (C) 2024 Analog Devices Inc. */


I've corrected the copyright date to 2025. I did a rebase again to squash

nunojsa · 2025-11-06T13:26:07Z

arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev10-ad9467-fmc-250ebz.dts

+ * hdl_project: <ad9467_fmc/zed>
+ * board_revision: <>
+ *
+ * Copyright (C) 2016-2019 Analog Devices Inc.


I've corrected the copyright date to 2025. I did a rebase again to squash

sarpadi · 2025-11-10T08:32:59Z

HDL project was merged to main

nunojsa

Please fix your commit messages. It seems you somehow screw the up during the last rebase

Mainly copied from the Zedboard dts. Modified to be similar to other ZCU102 dts files. Signed-off-by: JRabacca <[email protected]>

This is to provide support for the ZCU102 AD9467 Signed-off-by: JRabacca <[email protected]>

JRabacca · 2025-11-11T05:16:56Z

Please fix your commit messages. It seems you somehow screw the up during the last rebase

Was this about the one commit that had an additional message about correcting copyright dates?
I've rebase->reword that commit to remove the added message.

nunojsa · 2025-11-11T09:00:47Z

Was this about the one commit that had an additional message about correcting copyright dates?
I've rebase->reword that commit to remove the added message.

Yes, and two signed-of-by tags

JRabacca requested review from CiprianRegus, amiclaus, btogorean, buha, chegbeli, danmois, dbogdan, machschmitt, mhennerich, nunojsa and rbolboac as code owners September 25, 2025 05:52

IuliaCMoldovan mentioned this pull request Sep 25, 2025

projects/ad9467_fmc: Add support on ZCU102 analogdevicesinc/hdl#1924

Merged

13 tasks

nunojsa reviewed Oct 2, 2025

View reviewed changes

JRabacca force-pushed the main branch from d432ae8 to c19b6e4 Compare October 3, 2025 03:04

sarpadi requested a review from nunojsa October 17, 2025 09:47

JRabacca closed this Nov 6, 2025

JRabacca force-pushed the main branch from 4d1904a to 10d2a5d Compare November 6, 2025 01:11

JRabacca reopened this Nov 6, 2025

nunojsa reviewed Nov 6, 2025

View reviewed changes

JRabacca force-pushed the main branch from aab414b to db7d491 Compare November 7, 2025 02:51

sarpadi requested a review from nunojsa November 10, 2025 08:32

nunojsa reviewed Nov 10, 2025

View reviewed changes

JRabacca added 2 commits November 11, 2025 13:11

arm64: dts: xilinx: add AD9467 support for ZCU102

4b21d33

Mainly copied from the Zedboard dts. Modified to be similar to other ZCU102 dts files. Signed-off-by: JRabacca <[email protected]>

arm64: defconfig: add AD9467 firmware files

621a8ca

This is to provide support for the ZCU102 AD9467 Signed-off-by: JRabacca <[email protected]>

JRabacca force-pushed the main branch from db7d491 to 621a8ca Compare November 11, 2025 05:15

nunojsa approved these changes Nov 11, 2025

View reviewed changes

nunojsa merged commit 2449a08 into analogdevicesinc:main Nov 11, 2025
10 checks passed

		@@ -0,0 +1,50 @@
		// SPDX-License-Identifier: GPL-2.0
		/* Copyright (C) 2024 Analog Devices Inc. */

Added ZCU102 version for the AD9467 #2957

Added ZCU102 version for the AD9467 #2957

Conversation

JRabacca commented Sep 25, 2025 • edited by IuliaCMoldovan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Description

PR Type

PR Checklist

Uh oh!

nunojsa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JRabacca commented Oct 3, 2025

Uh oh!

nunojsa commented Oct 28, 2025

Uh oh!

JRabacca commented Nov 6, 2025

Uh oh!

nunojsa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sarpadi commented Nov 10, 2025

Uh oh!

nunojsa left a comment

Choose a reason for hiding this comment

Uh oh!

JRabacca commented Nov 11, 2025

Uh oh!

nunojsa commented Nov 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JRabacca commented Sep 25, 2025 •

edited by IuliaCMoldovan

Loading