Code changes in respond to PR comments and suggestions.

Signed-off-by: Oscar Magana Pantoja <[email protected]>

Author: omaganap

drivers/iio/adc/apollo/ad9088_ffh.c

@@ -6,7 +6,6 @@
  */
 #include <linux/types.h>
 #include <linux/kstrtox.h>
-#include <linux/kernel.h>
 #include "ad9088.h"
 
 adi_apollo_gpio_hop_profile_t hop_config = {{19, 20, 21, 22, 23}};
@@ -49,12 +48,12 @@ int ad9088_ffh_probe(struct ad9088_phy *phy)
 
 	/* Cache defaults */
 	memset(&phy->ffh, 0, sizeof(union ad9088_ffh));
-	for (uint8_t i = 0; i < ADI_APOLLO_FNCO_PROFILE_NUM; i++) {
-		for (uint8_t j = 0; j < 2; j++)
+	for (u8 i = 0; i < ADI_APOLLO_FNCO_PROFILE_NUM; i++) {
+		for (u8 j = 0; j < 2; j++)
 			phy->ffh.dir[j].fnco.mode[i] = cnco_hop_config.profile_sel_mode;
 	}
-	for (uint8_t i = 0; i < ADI_APOLLO_CNCO_PROFILE_NUM; i++) {
-		for (uint8_t j = 0; j < 2; j++)
+	for (u8 i = 0; i < ADI_APOLLO_CNCO_PROFILE_NUM; i++) {
+		for (u8 j = 0; j < 2; j++)
 			phy->ffh.dir[j].cnco.mode[i] = fnco_hop_config.profile_sel_mode;
 	}
 	return ret;
@@ -64,12 +63,12 @@ ssize_t ad9088_ext_info_read_ffh(struct iio_dev *indio_dev, uintptr_t private,
 				 const struct iio_chan_spec *chan, char *buf)
 {
 	struct axiadc_converter *conv = iio_device_get_drvdata(indio_dev);
-	uint8_t dir = chan->output ? ADI_APOLLO_TX : ADI_APOLLO_RX;
+	u8 dir = chan->output ? ADI_APOLLO_TX : ADI_APOLLO_RX;
 	struct ad9088_phy *phy = conv->phy;
-	uint8_t cddc_num, fddc_num, side;
-	uint32_t cddc_mask, fddc_mask;
-	uint64_t val;
-	uint8_t index;
+	u8 cddc_num, fddc_num, side;
+	u32 cddc_mask, fddc_mask;
+	u64 val;
+	u8 index;
 
 	guard(mutex)(&phy->lock);
 	ad9088_iiochan_to_fddc_cddc(phy, chan, &fddc_num,
@@ -80,7 +79,7 @@ ssize_t ad9088_ext_info_read_ffh(struct iio_dev *indio_dev, uintptr_t private,
 		val = phy->ffh.dir[dir].fnco.index[fddc_num];
 		break;
 	case FFH_FNCO_FREQUENCY:
-		index = phy->ffh.dir[dir].fnco.index[cddc_num];
+		index = phy->ffh.dir[dir].fnco.index[fddc_num];
 		if (index >= ADI_APOLLO_FNCO_PROFILE_NUM)
 			return -EINVAL;
 		val = phy->ffh.dir[dir].fnco.frequency[index];
@@ -117,17 +116,17 @@ ssize_t ad9088_ext_info_write_ffh(struct iio_dev *indio_dev, uintptr_t private,
 				  const char *buf, size_t len)
 {
 	struct axiadc_converter *conv = iio_device_get_drvdata(indio_dev);
-	uint8_t dir = chan->output ? ADI_APOLLO_TX : ADI_APOLLO_RX;
-	uint8_t cddc_num, fddc_num, side, fnco_num, cnco_num;
-	uint8_t index;
+	u8 dir = chan->output ? ADI_APOLLO_TX : ADI_APOLLO_RX;
+	u8 cddc_num, fddc_num, side, fnco_num, cnco_num;
+	u8 index;
 	struct ad9088_phy *phy = conv->phy;
-	uint32_t cddc_mask, fddc_mask, ftw_u32;
-	uint32_t cddc_dcm;
-	uint16_t fnco_en, cnco_en;
+	u32 cddc_mask, fddc_mask, ftw_u32;
+	u32 cddc_dcm;
+	u16 fnco_en, cnco_en;
 	bool hop_enable;
-	uint64_t val, ret;
-	uint64_t ftw_u64, f, tmp;
-	uint64_t gpio, val2;
+	u64 val, ret;
+	u64 ftw_u64, f, tmp;
+	u64 gpio, val2;
 
 	guard(mutex)(&phy->lock);
 	ad9088_iiochan_to_fddc_cddc(phy, chan, &fddc_num,