ci: Migrate build_check_new_file_license to GitHub Actions

Signed-off-by: Jorge Marques <[email protected]>

Author: gastmaier

.github/workflows/checks.yml

@@ -27,6 +27,11 @@ jobs:
         source ci/build.sh
         apply_prerun
 
+    - name: License
+      run: |
+        source ci/build.sh
+        check_license
+
     - name: Check patch
       run: |
         source ci/build.sh

azure-pipelines.yml

@@ -20,18 +20,6 @@ pool:
 stages:
   - stage: Build
     jobs:
-    - job: check_new_file_license
-      condition: eq(variables['Build.Reason'], 'PullRequest')
-      variables:
-        BUILD_TYPE: check_new_file_license
-        TARGET_BRANCH: $[ variables['System.PullRequest.TargetBranch'] ]
-      steps:
-      - checkout: self
-        fetchDepth: 50
-        clean: true
-      - script: ./ci/travis/run-build.sh
-        displayName: 'Check Is New ADI Driver & Dual Licensed'
-
     - job: microblaze_build_test
       variables:
         BUILD_TYPE: microblaze

ci/build.sh

@@ -324,6 +324,49 @@ check_cppcheck () {
 	return
 }
 
+_bad_licence_error() {
+	local license_error="
+	File is being added to Analog Devices Linux tree.%0A
+	Analog Devices code is being marked dual-licensed... Make sure this is really intended!%0A
+	If not intended, change MODULE_LICENSE() or the SPDX-License-Identifier accordingly.%0A
+	This is not as simple as one thinks and upstream might require a lawyer to sign the patches!"
+	echo "::warning file=$1::check_license: $license_error" | tr -d '\t\n' ; echo
+}
+
+check_license() {
+	local fail=0
+
+	echo "check_file_license on range $base_sha..$head_sha"
+
+	local added_files=$(git diff --diff-filter=A --name-only "$base_sha..$head_sha")
+
+	# Get list of new files in the commit range
+	for file in $added_files ; do
+		if git diff $base_sha..$head_sha "$file" 2>/dev/null | grep "^+MODULE_LICENSE" | grep -q "Dual" ; then
+			_bad_licence_error "$file"
+			fail=1
+		elif git diff $base_sha..$head_sha "$file" 2>/dev/null | grep "^+// SPDX-License-Identifier:" | grep -qi " OR " ; then
+			# The below might catch bad licenses in header files and also helps to make sure dual licenses are
+			# not in driver (e.g.: sometimes people have MODULE_LICENSE != SPDX-License-Identifier - which is also
+			# wrong and maybe something to improve in this job).
+			# For devicetree-related files, allow dual license if GPL-2.0 is one of them.
+			if [[ "$file" == *.@(yaml|dts|dtsi|dtso) ]]; then
+				if cat "$file" | grep "^// SPDX-License-Identifier:" | grep -q "GPL-2.0" ; then
+					continue
+				fi
+			fi
+			_bad_licence_error "$file"
+			fail=1
+		fi
+	done
+
+	if [[ "$fail" == "1" ]]; then
+		set_step_fail "check_file_license"
+	fi
+
+	return
+}
+
 compile_devicetree() {
 	local tmp_log_file=/dev/shm/$run_id.ci_compile_devicetree.log
 	local err=0

ci/travis/run-build.sh

@@ -153,50 +153,6 @@ get_ref_branch() {
 	fi
 }
 
-bad_licence_error() {
-       __echo_red "File '$1' is being added to Analog Devices Linux tree."
-       __echo_red "Analog Devices code is being marked dual-licensed... Make sure this is really intended!"
-       __echo_red "If not intended, change MODULE_LICENSE() or the SPDX-License-Identifier accordingly."
-       __echo_red "This is not as simple as one thinks and upstream might require a lawyer to sign the patches!"
-}
-
-build_check_new_file_license() {
-	local ret
-
-	local ref_branch="$(get_ref_branch)"
-
-	if [ -z "$ref_branch" ] ; then
-		__echo_red "Could not get a base_ref for checkpatch"
-		exit 1
-	fi
-
-	__update_git_ref "${ref_branch}" "${ref_branch}"
-
-	COMMIT_RANGE="${ref_branch}.."
-
-	__echo_green "Running check_new_adi_file_license for commit range '$COMMIT_RANGE'"
-
-	ret=0
-	# Get list of new files in the commit range
-	for file in $(git diff --name-status "$COMMIT_RANGE" | grep ^A | cut -d$'\t' -f2) ; do
-		if git diff "$COMMIT_RANGE" "$file" | grep "+MODULE_LICENSE" | grep -q "Dual" ; then
-			bad_licence_error "$file"
-			ret=1
-		elif git diff "$COMMIT_RANGE" "$file" | grep "SPDX-License-Identifier:" | grep -qi " OR " ; then
-			# The below might catch bad licenses in header files and also helps to make sure dual licenses are
-			# not in driver (eg: sometimes people have MODULE_LICENSE != SPDX-License-Identifier - which is also
-			# wrong and maybe someting to improve in this job)
-			if echo "$file" | grep -q ".yaml$"; then
-				continue
-			fi
-			bad_licence_error "$file"
-			ret=1
-		fi
-	done
-
-	return $ret
-}
-
 __setup_dummy_git_account() {
 	[ "${LOCAL_BUILD}" == "y" ] && return 0
 	# setup an email account so that we can cherry-pick stuff