dns_sd: qualify IIO_ERROR message before it prints out

rgetz · rgetz · commit 670af70293a6 · 2020-05-13T14:21:22.000-04:00
After a loop finishes (normally by a 'break;') only print out
the IIO_ERROR message if there was an error (was no 'break;').

This resolves some random message printing out:
ERROR: dnssd_remove_node call when 1 exceeds list length (1)
when doing dns-sd (iio_info -s).

Signed-off-by: Robin Getz &lt;robin.getz@analog.com&gt;
diff --git a/dns_sd.c b/dns_sd.c
@@ -53,7 +53,8 @@ static void dnssd_remove_node(struct dns_sd_discovery_data **ddata, int n)
 			ldata = ndata;
 			i++;
 		}
-		IIO_ERROR("dnssd_remove_node call when %i exceeds list length (%i)\n", n, i);
+		if (i < n)
+			IIO_ERROR("dnssd_remove_node call when %i exceeds list length (%i)\n", n, i);
 	}
 
 	*ddata = d;

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,8 @@ static void dnssd_remove_node(struct dns_sd_discovery_data **ddata, int n)`
`53`	`53`	`ldata = ndata;`
`54`	`54`	`i++;`
`55`	`55`	`}`
`56`		`- IIO_ERROR("dnssd_remove_node call when %i exceeds list length (%i)\n", n, i);`
	`56`	`+ if (i < n)`
	`57`	`+ IIO_ERROR("dnssd_remove_node call when %i exceeds list length (%i)\n", n, i);`
`57`	`58`	`}`
`58`	`59`
`59`	`60`	`*ddata = d;`