Download naming + timer issue fix

Author: alyssaxuu

build/background.bundle.js

@@ -1 +1 @@
-{"description":"__MSG_extDesc__","version":"3.1.12","manifest_version":3,"name":"__MSG_extName__","default_locale":"en","background":{"service_worker":"background.bundle.js"},"action":{"default_icon":"assets/img/icon-34.png"},"icons":{"128":"assets/img/icon-128.png"},"host_permissions":["<all_urls>"],"content_scripts":[{"matches":["<all_urls>"],"js":["contentScript.bundle.js"],"css":["assets/fonts/fonts.css"]}],"web_accessible_resources":[{"resources":["content.styles.css","blank.mp4","playground.html","editor.html","assets/*","setup.html","worker.js","vendor/*","recorder.html","recorderoffscreen.html","sandbox.html","wrapper.html","camera.html","permissions.html","region.html","waveform.html","playground.html","editorfallback.html","download.html","*"],"matches":["<all_urls>"]}],"oauth2":{"client_id":"560517327251-m7n1k3kddknu7s9s4ejvrs1bj91gutd7.apps.googleusercontent.com","scopes":["https://www.googleapis.com/auth/drive.file"]},"cross_origin_embedder_policy":{"value":"require-corp"},"cross_origin_opener_policy":{"value":"same-origin"},"content_security_policy":{"sandbox":"sandbox allow-scripts allow-modals allow-popups; script-src 'self' 'unsafe-inline' 'unsafe-eval' blob:; object-src 'self';worker-src 'self' blob: ;","extension_pages":"script-src 'self' 'wasm-unsafe-eval'; object-src 'self'; media-src 'self' data: blob: *;"},"sandbox":{"pages":["editor.html"]},"commands":{"start-recording":{"suggested_key":{"default":"Alt+Shift+G"},"description":"Start recording"},"cancel-recording":{"suggested_key":{"default":"Alt+Shift+X"},"description":"Cancel recording"},"pause-recording":{"suggested_key":{"default":"Alt+Shift+M"},"description":"Pause/Resume recording"}},"permissions":["identity","activeTab","storage","unlimitedStorage","downloads","tabs","tabCapture","scripting"],"optional_permissions":["offscreen","desktopCapture","alarms"]}
+{"description":"__MSG_extDesc__","version":"3.1.13","manifest_version":3,"name":"__MSG_extName__","default_locale":"en","background":{"service_worker":"background.bundle.js"},"action":{"default_icon":"assets/img/icon-34.png"},"icons":{"128":"assets/img/icon-128.png"},"host_permissions":["<all_urls>"],"content_scripts":[{"matches":["<all_urls>"],"js":["contentScript.bundle.js"],"css":["assets/fonts/fonts.css"]}],"web_accessible_resources":[{"resources":["content.styles.css","blank.mp4","playground.html","editor.html","assets/*","setup.html","worker.js","vendor/*","recorder.html","recorderoffscreen.html","sandbox.html","wrapper.html","camera.html","permissions.html","region.html","waveform.html","playground.html","editorfallback.html","download.html","*"],"matches":["<all_urls>"]}],"oauth2":{"client_id":"560517327251-m7n1k3kddknu7s9s4ejvrs1bj91gutd7.apps.googleusercontent.com","scopes":["https://www.googleapis.com/auth/drive.file"]},"cross_origin_embedder_policy":{"value":"require-corp"},"cross_origin_opener_policy":{"value":"same-origin"},"content_security_policy":{"sandbox":"sandbox allow-scripts allow-modals allow-popups; script-src 'self' 'unsafe-inline' 'unsafe-eval' blob:; object-src 'self';worker-src 'self' blob: ;","extension_pages":"script-src 'self' 'wasm-unsafe-eval'; object-src 'self'; media-src 'self' data: blob: *;"},"sandbox":{"pages":["editor.html"]},"commands":{"start-recording":{"suggested_key":{"default":"Alt+Shift+G"},"description":"Start recording"},"cancel-recording":{"suggested_key":{"default":"Alt+Shift+X"},"description":"Cancel recording"},"pause-recording":{"suggested_key":{"default":"Alt+Shift+M"},"description":"Pause/Resume recording"}},"permissions":["identity","activeTab","storage","unlimitedStorage","downloads","tabs","tabCapture","scripting"],"optional_permissions":["offscreen","desktopCapture","alarms"]}

build/download.bundle.js

@@ -3,7 +3,7 @@
   "name": "__MSG_extName__",
   "description": "__MSG_extDesc__",
   "default_locale": "en",
-  "version": "3.1.12",
+  "version": "3.1.13",
   "background": {
     "service_worker": "background.bundle.js"
   },

build/manifest.json

@@ -179,12 +179,18 @@ const handleAlarm = async (alarm) => {
     const { recording } = await chrome.storage.local.get(["recording"]);
     if (recording) {
       stopRecording();
-      const { recordingTab } = await chrome.storage.local.get(["recordingTab"]);
-      sendMessageTab(recordingTab, { type: "stop-recording-tab" });
+
       const { activeTab } = await chrome.storage.local.get(["activeTab"]);
-      sendMessageTab(activeTab, { type: "stop-recording-tab" });
-      const currentTab = await getCurrentTab();
-      sendMessageTab(currentTab.id, { type: "stop-recording-tab" });
+
+      // Check if actual tab
+      chrome.tabs.get(activeTab, (t) => {
+        if (t) {
+          sendMessageTab(activeTab, { type: "stop-recording-tab" });
+        } else {
+          sendMessageTab(tab.id, { type: "stop-recording-tab" });
+          chrome.storage.local.set({ activeTab: tab.id });
+        }
+      });
     }
     chrome.alarms.clear("recording-alarm");
   }

build/sandbox.bundle.js

@@ -41,8 +41,9 @@ const Download = () => {
     if (message.type === "download-video") {
       const base64 = message.base64;
       const blob = base64ToUint8Array(base64);
-      const title = message.title;
+      const title = message.title.replace(/[\/\\:?~<>|*"]/g, "_");
       const url = URL.createObjectURL(blob);
+
       chrome.downloads
         .download({
           url: url,

src/manifest.json

@@ -809,7 +809,7 @@ const ContentState = (props) => {
     // The title must not have these characters  " : ? ~ < > * |
     // Replace them with a space
     const title =
-      contentStateRef.current.title.replace(/[:?~<>|*]/g, " ") + ext;
+      contentStateRef.current.title.replace(/[\/\\:?~<>|*]/g, " ") + ext;
 
     // Check if user is on Brave browser
     if ((navigator.brave && (await navigator.brave.isBrave())) || false) {