Remove PageRepository.move_page method

Replace with direct call to Page#move_page. This was the last
remaining method in PageRepository, so the class has been deleted.

Author: stephencdaly

app/controllers/pages_controller.rb

@@ -77,11 +77,15 @@ def start_new_question
   end
 
   def move_page
-    page_to_move = current_form.pages.find(move_params[:page_id])
+    page = current_form.pages.find(move_params[:page_id])
+    page.move_page(move_params[:direction])
 
-    moved_page = PageRepository.move_page(page_to_move, move_params[:direction])
+    success_message = t("banner.success.form.page_moved",
+                        question_text: page.question_text,
+                        direction: move_params[:direction],
+                        question_number: page.position)
 
-    redirect_to form_pages_path, success: t("banner.success.form.page_moved", question_text: page_to_move.question_text, direction: move_params[:direction], question_number: moved_page.position)
+    redirect_to form_pages_path, success: success_message
   end
 
 private
@@ -119,8 +123,8 @@ def setup_draft_question_for_existing_page
 
     if edit_draft_question.new_record?
       attributes = page.attributes
-        .slice(*edit_draft_question.attribute_names)
-        .except("id")
+                       .slice(*edit_draft_question.attribute_names)
+                       .except("id")
       edit_draft_question.attributes = attributes
       edit_draft_question.save!(validate: false)
     end

app/services/page_repository.rb

@@ -313,53 +313,44 @@
   describe "#move_page" do
     let(:form) { create(:form, :with_pages) }
     let(:pages) { form.pages }
+    let(:page) { pages.second }
 
     before do
       GroupForm.create!(form_id: form.id, group_id: group.id)
     end
 
     context "when moving the page up", :capture_logging do
-      before do
-        allow(PageRepository).to receive(:move_page) do |page, _direction|
-          page.move_higher
-          page
-        end
-
-        post move_page_path({ form_id: form.id, move_direction: { up: pages[1].id } })
-      end
-
       it "logs the params" do
-        expect(log_line["params"]).to include "move_direction" => { "up" => pages[1].id.to_s }
+        post move_page_path({ form_id: form.id, move_direction: { up: page.id } })
+        expect(log_line["params"]).to include "move_direction" => { "up" => page.id.to_s }
       end
 
-      it "calls the page repository to move the page up" do
-        expect(PageRepository).to have_received(:move_page).with(pages[1], :up)
+      it "moves the page up" do
+        expect {
+          post move_page_path({ form_id: form.id, move_direction: { up: page.id } })
+        }.to change { page.reload.position }.from(2).to(1)
       end
 
       it "renders a success banner with the page's new position" do
+        post move_page_path({ form_id: form.id, move_direction: { up: page.id } })
         expect(flash[:success]).to eq("‘#{pages[1].question_text}’ has moved up to number 1")
       end
     end
 
     context "when moving the page down", :capture_logging do
-      before do
-        allow(PageRepository).to receive(:move_page) do |page, _direction|
-          page.move_lower
-          page
-        end
-
-        post move_page_path({ form_id: form.id, move_direction: { down: pages[1].id } })
-      end
-
       it "logs the params" do
-        expect(log_line["params"]).to include "move_direction" => { "down" => pages[1].id.to_s }
+        post move_page_path({ form_id: form.id, move_direction: { down: page.id } })
+        expect(log_line["params"]).to include "move_direction" => { "down" => page.id.to_s }
       end
 
-      it "calls the page repository to move the page down" do
-        expect(PageRepository).to have_received(:move_page).with(pages[1], :down)
+      it "moves the page down" do
+        expect {
+          post move_page_path({ form_id: form.id, move_direction: { down: page.id } })
+        }.to change { page.reload.position }.from(2).to(3)
       end
 
       it "renders a success banner with the page's new position" do
+        post move_page_path({ form_id: form.id, move_direction: { down: page.id } })
         expect(flash[:success]).to eq("‘#{pages[1].question_text}’ has moved down to number 3")
       end
     end