Add handling when group is deleted during move

Author: chao-xian

app/controllers/group_forms_controller.rb

@@ -44,10 +44,20 @@ def update
 
     if @group_select.valid?
       receiving_group = Group.find_by(external_id: @group_select.group)
-      @group_form.update!(group: receiving_group)
-      success_message = t(".success", form_name: @form.name, receiving_group_name: receiving_group.name)
 
-      redirect_to @group, success: success_message, status: :see_other
+      # In case the receiving group is deleted since the form was loaded
+      if receiving_group
+        @group_form.update!(group: receiving_group)
+        success_message = t(".success", form_name: @form.name, receiving_group_name: receiving_group.name)
+
+        redirect_to @group, success: success_message, status: :see_other
+      else
+        @group_select = Forms::GroupSelect.new(group: @group, form: @form)
+        @group_select_presenter = Forms::GroupSelectPresenter.call(group: @group, groups: @group_select.groups, form: @form)
+        @group_select.errors.add(:group, :gone)
+
+        render :edit, status: :unprocessable_content
+      end
     else
       @group_select = Forms::GroupSelect.new(group: @group, form: @form)
       @group_select_presenter = Forms::GroupSelectPresenter.call(group: @group, groups: @group_select.groups, form: @form)

config/locales/input_objects/group_select.yml

@@ -7,6 +7,7 @@ en:
           attributes:
             group:
               blank: Select the group you want to move this form to
+              gone: The group you selected no longer exists
   helpers:
     hint:
       forms_group_select:

spec/features/group_form/move_form_spec.rb

@@ -41,7 +41,15 @@
       given_i_am_logged_in_as_an_organisation_admin
       and_i_see_the_move_form_page
       when_i_do_not_choose_a_group
-      then_i_see_an_error_message
+      then_i_see_an_error_message_to_select_a_group
+    end
+
+    scenario "receiving group is deleted before moving form" do
+      given_i_am_logged_in_as_an_organisation_admin
+      and_i_see_the_move_form_page
+      and_the_receiving_group_is_deleted
+      when_i_change_the_group
+      then_i_see_an_error_message_the_group_is_gone
     end
   end
 
@@ -87,6 +95,10 @@ def and_i_see_the_move_form_page
     expect(page.find("h1")).to have_content("#{form.name}\n-\nMove this form to a different group")
   end
 
+  def and_the_receiving_group_is_deleted
+    another_group.destroy!
+  end
+
   def when_i_change_the_group
     choose(another_group.name)
     click_button "Continue"
@@ -109,8 +121,13 @@ def when_i_do_not_choose_a_group
     click_button "Continue"
   end
 
-  def then_i_see_an_error_message
+  def then_i_see_an_error_message_to_select_a_group
     expect(page).to have_content("There is a problem")
     expect(page).to have_content("Select the group you want to move this form to")
   end
+
+  def then_i_see_an_error_message_the_group_is_gone
+    expect(page).to have_content("There is a problem")
+    expect(page).to have_content("The group you selected no longer exists")
+  end
 end