fix: revert logging to the same schema as it used to be (#466)

Author: gr2m

api/github/webhooks.js

@@ -1,13 +1,8 @@
 const { createNodeMiddleware, createProbot } = require("probot");
-const pino = require("pino");
 
 const app = require("../../app");
 
 module.exports = createNodeMiddleware(app, {
-  probot: createProbot({
-    overrides: {
-      log: pino(),
-    },
-  }),
+  probot: createProbot(),
   webhooksPath: "/api/github/webhooks",
 });

lib/process-issue-comment.js

@@ -13,22 +13,8 @@ async function processIssueComment({ context, commentReply }) {
 
   const { action, contributors } = parseComment(commentBody);
 
-  const log = context.log.child({
-    action,
-    contributors,
-    account: repo.owner.id,
-    accountType: repo.owner.type.toLowerCase(),
-    accountLogin: repo.owner.login,
-    createdBy: createdBy.id,
-    createdByLogin: createdBy.login,
-    createdByType: createdBy.type.toLowerCase(),
-    repository: repo.id,
-    private: repo.private,
-    success: false,
-  });
-
   if (action !== "add") {
-    log.info(`Unknown action "${action}"`);
+    context.log.info(`Unknown action "${action}"`);
     commentReply.reply(`I could not determine your intention.`);
     commentReply.reply(
       `Basic usage: @all-contributors please add @someone for code, doc and infra`
@@ -40,15 +26,44 @@ async function processIssueComment({ context, commentReply }) {
   }
 
   for (var contributor in contributors) {
-    const who = contributor
-    const contributions = contributors[who]
+    const who = contributor;
+    const contributions = contributors[who];
     const branchName = `all-contributors/add-${toSafeGitReferenceName(who)}`;
 
-    await triggerActionAdd(context, commentReply, log, who, contributions, branchName)
+    const log = context.log.child({
+      who,
+      action,
+      contributions,
+      account: repo.owner.id,
+      accountType: repo.owner.type.toLowerCase(),
+      accountLogin: repo.owner.login,
+      createdBy: createdBy.id,
+      createdByLogin: createdBy.login,
+      createdByType: createdBy.type.toLowerCase(),
+      repository: repo.id,
+      private: repo.private,
+      success: false,
+    });
+
+    await triggerActionAdd(
+      context,
+      commentReply,
+      log,
+      who,
+      contributions,
+      branchName
+    );
   }
 }
 
-async function triggerActionAdd(context, commentReply, log, who, contributions, branchName) {
+async function triggerActionAdd(
+  context,
+  commentReply,
+  log,
+  who,
+  contributions,
+  branchName
+) {
   if (contributions.length === 0) {
     log.info("No contributions");
     commentReply.reply(
@@ -77,13 +92,13 @@ async function triggerActionAdd(context, commentReply, log, who, contributions,
     branchName,
   });
 
-  if(!pullCreated) {
+  if (!pullCreated) {
     log.info(
-        {
-          pullCreated,
-          success: true,
-        },
-        `${who} already have ${contributions.join(", ")}`
+      {
+        pullCreated,
+        success: true,
+      },
+      `${who} already have ${contributions.join(", ")}`
     );
     return;
   }

package-lock.json

@@ -29,7 +29,6 @@
     "got": ">=11.8.5",
     "jest": "^27.3.1",
     "nock": "^13.1.4",
-    "pino": "^6.11.2",
     "prettier": "^2.4.1",
     "smee-client": "^1.2.3",
     "vercel": "^28.15.3"