Skip to content

Commit d92f995

Browse files
authored
fix: resolves depsEqual performance issues (#2577) (#2578)
1 parent d02d146 commit d92f995

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/hooks/src/createDeepCompareEffect/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ export const createDeepCompareEffect: CreateUpdateEffect = (hook) => (effect, de
1010
const signalRef = useRef<number>(0);
1111

1212
if (deps === undefined || !depsEqual(deps, ref.current)) {
13-
ref.current = deps;
1413
signalRef.current += 1;
1514
}
15+
ref.current = deps;
1616

1717
hook(effect, [signalRef.current]);
1818
};

packages/hooks/src/utils/useDeepCompareWithTarget.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ const useDeepCompareEffectWithTarget = (
1313
const signalRef = useRef<number>(0);
1414

1515
if (!depsEqual(deps, ref.current)) {
16-
ref.current = deps;
1716
signalRef.current += 1;
1817
}
18+
ref.current = deps;
1919

2020
useEffectWithTarget(effect, [signalRef.current], target);
2121
};

0 commit comments

Comments
 (0)