Skip to content

Commit 326067f

Browse files
committed
perf(core): improve performance
1 parent 27ec247 commit 326067f

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

packages/core/src/effects/useDragDropEffect.ts

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -120,31 +120,26 @@ export const useDragDropEffect = (engine: Engine) => {
120120
closestDirection === ClosestDirection.Under
121121
) {
122122
if (closestNode.allowSibling(dragNodes)) {
123-
requestIdle(() => {
124-
selection.batchSafeSelect(closestNode.insertAfter(...dragNodes))
125-
})
123+
selection.batchSafeSelect(closestNode.insertAfter(...dragNodes))
126124
}
127125
} else if (
128126
closestDirection === ClosestDirection.Before ||
129127
closestDirection === ClosestDirection.Upper
130128
) {
131129
if (closestNode.allowSibling(dragNodes)) {
132-
const newNodes = closestNode.insertBefore(...dragNodes)
133-
selection.batchSafeSelect(newNodes)
130+
selection.batchSafeSelect(closestNode.insertBefore(...dragNodes))
134131
}
135132
} else if (
136133
closestDirection === ClosestDirection.Inner ||
137134
closestDirection === ClosestDirection.InnerAfter
138135
) {
139136
if (closestNode.allowAppend(dragNodes)) {
140-
const newNodes = closestNode.appendNode(...dragNodes)
141-
selection.batchSafeSelect(newNodes)
137+
selection.batchSafeSelect(closestNode.appendNode(...dragNodes))
142138
operation.setDropNode(closestNode)
143139
}
144140
} else if (closestDirection === ClosestDirection.InnerBefore) {
145141
if (closestNode.allowAppend(dragNodes)) {
146-
const newNodes = closestNode.prependNode(...dragNodes)
147-
selection.batchSafeSelect(newNodes)
142+
selection.batchSafeSelect(closestNode.prependNode(...dragNodes))
148143
operation.setDropNode(closestNode)
149144
}
150145
}

0 commit comments

Comments
 (0)