Skip to content

Commit 15dea64

Browse files
committed
perf(core): improve performance
1 parent 8a672dd commit 15dea64

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

packages/core/src/effects/useDragDropEffect.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,24 +129,27 @@ export const useDragDropEffect = (engine: Engine) => {
129129
closestDirection === ClosestDirection.Upper
130130
) {
131131
if (closestNode.allowSibling(dragNodes)) {
132+
const newNodes = closestNode.insertBefore(...dragNodes)
132133
requestIdle(() => {
133-
selection.batchSafeSelect(closestNode.insertBefore(...dragNodes))
134+
selection.batchSafeSelect(newNodes)
134135
})
135136
}
136137
} else if (
137138
closestDirection === ClosestDirection.Inner ||
138139
closestDirection === ClosestDirection.InnerAfter
139140
) {
140141
if (closestNode.allowAppend(dragNodes)) {
142+
const newNodes = closestNode.appendNode(...dragNodes)
141143
requestIdle(() => {
142-
selection.batchSafeSelect(closestNode.appendNode(...dragNodes))
144+
selection.batchSafeSelect(newNodes)
143145
})
144146
operation.setDropNode(closestNode)
145147
}
146148
} else if (closestDirection === ClosestDirection.InnerBefore) {
147149
if (closestNode.allowAppend(dragNodes)) {
150+
const newNodes = closestNode.prependNode(...dragNodes)
148151
requestIdle(() => {
149-
selection.batchSafeSelect(closestNode.prependNode(...dragNodes))
152+
selection.batchSafeSelect(newNodes)
150153
})
151154
operation.setDropNode(closestNode)
152155
}

0 commit comments

Comments
 (0)